add 0x14 ClearDiagnosticInformation#87
Merged
driftregion merged 5 commits intodriftregion:mainfrom Sep 15, 2025
Merged
Conversation
Signed-off-by: Fabian Gajek <fabian.gajek@frickly.systems>
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
Contributor
Author
|
I used a slightly different bazel version (8.4.1) and gcc to generate the iso14229.c/h files diff --git a/.bazelversion b/.bazelversion
index 0e79152..6da4de5 100644
--- a/.bazelversion
+++ b/.bazelversion
@@ -1 +1 @@
-8.1.1
+8.4.1
diff --git a/toolchain/BUILD b/toolchain/BUILD
index 6ee76bc..c05efe6 100644
--- a/toolchain/BUILD
+++ b/toolchain/BUILD
@@ -77,6 +77,8 @@ gcc_toolchain(
include_dirs = [
"/usr/lib/gcc/x86_64-linux-gnu/11/include/",
'/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+ '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+ '/usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include/',
],
target_compatible_with = [
"@platforms//cpu:x86_64",
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #87 +/- ##
===========================================
- Coverage 57.29% 31.42% -25.87%
===========================================
Files 6 2 -4
Lines 3004 2097 -907
Branches 609 428 -181
===========================================
- Hits 1721 659 -1062
- Misses 903 1303 +400
+ Partials 380 135 -245 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
Great work |
Owner
Thanks for this background. There is an ongoing task to make the toolchains and linters hermetic. You chose the right approach for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR should add support for the 0x14 ClearDiagnosticInformation function.
I noticed some formatting issues in the test_server.c file. These are addressed in this commit. Only this commit should contain relevant changes.