Skip to content

add 0x14 ClearDiagnosticInformation#87

Merged
driftregion merged 5 commits intodriftregion:mainfrom
frickly-systems:tim/feat/0x14-clear-dtc
Sep 15, 2025
Merged

add 0x14 ClearDiagnosticInformation#87
driftregion merged 5 commits intodriftregion:mainfrom
frickly-systems:tim/feat/0x14-clear-dtc

Conversation

@ParaZera
Copy link
Contributor

The PR should add support for the 0x14 ClearDiagnosticInformation function.

  • added a handler for the 0x14 function
  • added event and arg-struct
  • added tests for happy path, malformed request and negative response

I noticed some formatting issues in the test_server.c file. These are addressed in this commit. Only this commit should contain relevant changes.

f43i4n and others added 5 commits September 2, 2025 11:29
Signed-off-by: Fabian Gajek <fabian.gajek@frickly.systems>
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
@ParaZera
Copy link
Contributor Author

I used a slightly different bazel version (8.4.1) and gcc to generate the iso14229.c/h files

diff --git a/.bazelversion b/.bazelversion
index 0e79152..6da4de5 100644
--- a/.bazelversion
+++ b/.bazelversion
@@ -1 +1 @@
-8.1.1
+8.4.1
diff --git a/toolchain/BUILD b/toolchain/BUILD
index 6ee76bc..c05efe6 100644
--- a/toolchain/BUILD
+++ b/toolchain/BUILD
@@ -77,6 +77,8 @@ gcc_toolchain(
     include_dirs = [
         "/usr/lib/gcc/x86_64-linux-gnu/11/include/",
         '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include/',
     ],
     target_compatible_with = [
         "@platforms//cpu:x86_64",

@codecov
Copy link

codecov bot commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.42%. Comparing base (1ed564a) to head (de44210).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #87       +/-   ##
===========================================
- Coverage   57.29%   31.42%   -25.87%     
===========================================
  Files           6        2        -4     
  Lines        3004     2097      -907     
  Branches      609      428      -181     
===========================================
- Hits         1721      659     -1062     
- Misses        903     1303      +400     
+ Partials      380      135      -245     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@driftregion
Copy link
Owner

Great work

@driftregion driftregion merged commit 902c172 into driftregion:main Sep 15, 2025
6 of 7 checks passed
@driftregion
Copy link
Owner

I used a slightly different bazel version (8.4.1) and gcc to generate the iso14229.c/h files

diff --git a/.bazelversion b/.bazelversion
index 0e79152..6da4de5 100644
--- a/.bazelversion
+++ b/.bazelversion
@@ -1 +1 @@
-8.1.1
+8.4.1
diff --git a/toolchain/BUILD b/toolchain/BUILD
index 6ee76bc..c05efe6 100644
--- a/toolchain/BUILD
+++ b/toolchain/BUILD
@@ -77,6 +77,8 @@ gcc_toolchain(
     include_dirs = [
         "/usr/lib/gcc/x86_64-linux-gnu/11/include/",
         '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include/',
     ],
     target_compatible_with = [
         "@platforms//cpu:x86_64",

Thanks for this background. There is an ongoing task to make the toolchains and linters hermetic. You chose the right approach for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants