add 0x2F InputOutputControlByIdentifier#88
Merged
driftregion merged 3 commits intodriftregion:mainfrom Sep 16, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
===========================================
- Coverage 57.80% 32.07% -25.74%
===========================================
Files 6 2 -4
Lines 3055 2114 -941
Branches 621 430 -191
===========================================
- Hits 1766 678 -1088
- Misses 899 1301 +402
+ Partials 390 135 -255 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ParaZera
force-pushed
the
tim/feat/io-control
branch
from
2dcdd7a to
d02d1bc
Compare
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
…BY_IDENTIFIER The UDS Service is called InputOutputControlByIdentifier. The new name better reflects the "output" part. Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
I used a differente bazel and gcc version by applying the following patch before build: ```diff diff --git a/.bazelversion b/.bazelversion index 0e79152..6da4de5 100644 --- a/.bazelversion +++ b/.bazelversion @@ -1 +1 @@ -8.1.1 +8.4.1 diff --git a/toolchain/BUILD b/toolchain/BUILD index 6ee76bc..c05efe6 100644 --- a/toolchain/BUILD +++ b/toolchain/BUILD @@ -77,6 +77,8 @@ gcc_toolchain( include_dirs = [ "/usr/lib/gcc/x86_64-linux-gnu/11/include/", '/usr/lib/gcc/x86_64-linux-gnu/13/include/', + '/usr/lib/gcc/x86_64-linux-gnu/13/include/', + '/usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include/', ], target_compatible_with = [ "@platforms//cpu:x86_64", ```
ParaZera
force-pushed
the
tim/feat/io-control
branch
from
d02d1bc to
604720a
Compare
driftregion
approved these changes
Sep 16, 2025
Owner
|
Nice work @ParaZera |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR should add support for the 0x2F InputOutputControlByIdentifier function.
kSID_INPUT_CONTROL_BY_IDENTIFIERtokSID_IO_CONTROL_BY_IDENTIFIERto better reflect the function nameAgain for full context: I used a different bazel and gcc version to update the iso14229.c/h files