feat: 0x28 CommControl add NodeID Argument for Ctrl Types 0x04 and 0x05#95
Merged
driftregion merged 2 commits intodriftregion:mainfrom Sep 18, 2025
Merged
Conversation
Signed-off-by: Tim Schrader <tim.schrader@frickly.systems>
|
Owner
|
Looks good. Nice work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




nodeIdfield in theUDSCommCtrlArgs_tas it is required for control types 0x04 and 0x05As always, the iso14229.c/h files were created with a slightly differend bazel/gcc version: