Skip to content

feat: 0x28 CommControl add NodeID Argument for Ctrl Types 0x04 and 0x05#95

Merged
driftregion merged 2 commits intodriftregion:mainfrom
frickly-systems:tim/feat/0x28-comm-ctrl
Sep 18, 2025
Merged

feat: 0x28 CommControl add NodeID Argument for Ctrl Types 0x04 and 0x05#95
driftregion merged 2 commits intodriftregion:mainfrom
frickly-systems:tim/feat/0x28-comm-ctrl

Conversation

@ParaZera
Copy link
Contributor

  • added the nodeId field in the UDSCommCtrlArgs_t as it is required for control types 0x04 and 0x05
  • added tests for 0x28 CommControl

As always, the iso14229.c/h files were created with a slightly differend bazel/gcc version:

diff --git a/.bazelversion b/.bazelversion
index 0e79152..6da4de5 100644
--- a/.bazelversion
+++ b/.bazelversion
@@ -1 +1 @@
-8.1.1
+8.4.1
diff --git a/toolchain/BUILD b/toolchain/BUILD
index 6ee76bc..c05efe6 100644
--- a/toolchain/BUILD
+++ b/toolchain/BUILD
@@ -77,6 +77,8 @@ gcc_toolchain(
     include_dirs = [
         "/usr/lib/gcc/x86_64-linux-gnu/11/include/",
         '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-linux-gnu/13/include/',
+        '/usr/lib/gcc/x86_64-pc-linux-gnu/15.2.1/include/',
     ],
     target_compatible_with = [
         "@platforms//cpu:x86_64",

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
7 Security Hotspots
D Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@driftregion
Copy link
Owner

Looks good. Nice work.

@driftregion driftregion merged commit e3186c8 into driftregion:main Sep 18, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants