Merge branch 'main' into HEAD

Author: bhouston

.github/workflows/issue-comment.yml

@@ -54,13 +54,11 @@ jobs:
           # Auth GitHub CLI with the token
       - name: Configure GitHub CLI
         run: |
-          # First try with GITHUB_TOKEN
-          echo "${{ secrets.GITHUB_TOKEN }}" | gh auth login --with-token
+          echo "${{ secrets.GH_PAT }}" | gh auth login --with-token
           # Verify auth status
           gh auth status
 
       - env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           ANTHROPIC_API_KEY: ${{ secrets.ANTHROPIC_API_KEY }}
         run: |
           echo "Running MyCoder for issue #${{ github.event.issue.number }} with prompt: ${{ steps.extract-prompt.outputs.prompt }}"

packages/agent/CHANGELOG.md

@@ -1,21 +1,19 @@
 # mycoder-agent-v1.0.0 (2025-03-11)
 
-
 ### Bug Fixes
 
-* **monorepo:** implement semantic-release-monorepo for proper versioning of sub-packages ([96c6284](https://github.com/drivecore/mycoder/commit/96c62848fbc3a4c1c591f3fd6202486e6461c4f2))
-* only consider response empty if no text AND no tool calls ([#127](https://github.com/drivecore/mycoder/issues/127)) ([af20ec5](https://github.com/drivecore/mycoder/commit/af20ec54468afed49632306fe553b307ab3c4ba5))
-* Replace shell commands with Node.js APIs for cross-platform compatibility ([07b4c24](https://github.com/drivecore/mycoder/commit/07b4c24fa17d19c468a76404a367f6afc0005517))
-* token caching ([5972e59](https://github.com/drivecore/mycoder/commit/5972e59ab572040e564d1756ab8a5625215e14dc))
-* use maxTokens in generateTextProps ([bfb9da9](https://github.com/drivecore/mycoder/commit/bfb9da9804d61840344e93cc5bea809e8e16f2ec))
-
+- **monorepo:** implement semantic-release-monorepo for proper versioning of sub-packages ([96c6284](https://github.com/drivecore/mycoder/commit/96c62848fbc3a4c1c591f3fd6202486e6461c4f2))
+- only consider response empty if no text AND no tool calls ([#127](https://github.com/drivecore/mycoder/issues/127)) ([af20ec5](https://github.com/drivecore/mycoder/commit/af20ec54468afed49632306fe553b307ab3c4ba5))
+- Replace shell commands with Node.js APIs for cross-platform compatibility ([07b4c24](https://github.com/drivecore/mycoder/commit/07b4c24fa17d19c468a76404a367f6afc0005517))
+- token caching ([5972e59](https://github.com/drivecore/mycoder/commit/5972e59ab572040e564d1756ab8a5625215e14dc))
+- use maxTokens in generateTextProps ([bfb9da9](https://github.com/drivecore/mycoder/commit/bfb9da9804d61840344e93cc5bea809e8e16f2ec))
 
 ### Features
 
-* add back token tracking, system prompt caching. ([ddc04ab](https://github.com/drivecore/mycoder/commit/ddc04ab0778eb2f571897e825c8d8ba17651db09))
-* add showStdIn and showStdout options to shellMessage and shellStart ([aed1b9f](https://github.com/drivecore/mycoder/commit/aed1b9f6ba489da19f2170c136861a7c80ad6e33)), closes [#167](https://github.com/drivecore/mycoder/issues/167)
-* add token caching.  issue 145 ([d78723b](https://github.com/drivecore/mycoder/commit/d78723bb6d0514110088caf7009e196e3f79769e))
-* remove modelProvider and modelName - instant decrepation ([59834dc](https://github.com/drivecore/mycoder/commit/59834dcf932051a5c75624bd6f6ab12254f43769))
+- add back token tracking, system prompt caching. ([ddc04ab](https://github.com/drivecore/mycoder/commit/ddc04ab0778eb2f571897e825c8d8ba17651db09))
+- add showStdIn and showStdout options to shellMessage and shellStart ([aed1b9f](https://github.com/drivecore/mycoder/commit/aed1b9f6ba489da19f2170c136861a7c80ad6e33)), closes [#167](https://github.com/drivecore/mycoder/issues/167)
+- add token caching. issue 145 ([d78723b](https://github.com/drivecore/mycoder/commit/d78723bb6d0514110088caf7009e196e3f79769e))
+- remove modelProvider and modelName - instant decrepation ([59834dc](https://github.com/drivecore/mycoder/commit/59834dcf932051a5c75624bd6f6ab12254f43769))
 
 # mycoder-agent
 

packages/agent/src/tools/browser/BrowserManager.ts

@@ -15,6 +15,15 @@ export class BrowserManager {
     defaultTimeout: 30000,
   };
 
+  constructor() {
+    // Store a reference to the instance globally for cleanup
+    // This allows the CLI to access the instance for cleanup
+    (globalThis as any).__BROWSER_MANAGER__ = this;
+
+    // Set up cleanup handlers for graceful shutdown
+    this.setupGlobalCleanup();
+  }
+
   async createSession(config?: BrowserConfig): Promise<BrowserSession> {
     try {
       const sessionConfig = { ...this.defaultConfig, ...config };
@@ -80,14 +89,46 @@ export class BrowserManager {
       this.sessions.delete(session.id);
     });
 
-    // Handle process exit
+    // No need to add individual process handlers for each session
+    // We'll handle all sessions in the global cleanup
+  }
+
+  /**
+   * Sets up global cleanup handlers for all browser sessions
+   */
+  private setupGlobalCleanup(): void {
+    // Use beforeExit for async cleanup
+    process.on('beforeExit', () => {
+      this.closeAllSessions().catch((err) => {
+        console.error('Error closing browser sessions:', err);
+      });
+    });
+
+    // Use exit for synchronous cleanup (as a fallback)
     process.on('exit', () => {
-      this.closeSession(session.id).catch(() => {});
+      // Can only do synchronous operations here
+      for (const session of this.sessions.values()) {
+        try {
+          // Attempt synchronous close - may not fully work
+          session.browser.close();
+          // eslint-disable-next-line unused-imports/no-unused-vars
+        } catch (e) {
+          // Ignore errors during exit
+        }
+      }
     });
 
-    // Handle unexpected errors
-    process.on('uncaughtException', () => {
-      this.closeSession(session.id).catch(() => {});
+    // Handle SIGINT (Ctrl+C)
+    process.on('SIGINT', () => {
+      // eslint-disable-next-line promise/catch-or-return
+      this.closeAllSessions()
+        .catch(() => {
+          return false;
+        })
+        .finally(() => {
+          // Give a moment for cleanup to complete
+          setTimeout(() => process.exit(0), 500);
+        });
     });
   }
 

packages/agent/src/tools/system/shellStart.ts

@@ -25,6 +25,7 @@ type ProcessState = {
 };
 
 // Global map to store process state
+// This is exported so it can be accessed for cleanup
 export const processStates: Map<string, ProcessState> = new Map();
 
 const parameterSchema = z.object({

packages/cli/CHANGELOG.md

@@ -1,21 +1,19 @@
 # mycoder-v1.0.0 (2025-03-11)
 
-
 ### Bug Fixes
 
-* add deepmerge to cli package.json ([ab66377](https://github.com/drivecore/mycoder/commit/ab66377342c9f23fa874d2776e73d365141e8801))
-* don't save consent when using --userWarning=false ([41cf69d](https://github.com/drivecore/mycoder/commit/41cf69dee22acc31cd0f2aa9f80e36cd867fb20b))
-* **monorepo:** implement semantic-release-monorepo for proper versioning of sub-packages ([96c6284](https://github.com/drivecore/mycoder/commit/96c62848fbc3a4c1c591f3fd6202486e6461c4f2))
-* update hierarchical configuration system to fix failing tests ([93d949c](https://github.com/drivecore/mycoder/commit/93d949c03b7ebe96bad36713f6476c38d2a35224))
-
+- add deepmerge to cli package.json ([ab66377](https://github.com/drivecore/mycoder/commit/ab66377342c9f23fa874d2776e73d365141e8801))
+- don't save consent when using --userWarning=false ([41cf69d](https://github.com/drivecore/mycoder/commit/41cf69dee22acc31cd0f2aa9f80e36cd867fb20b))
+- **monorepo:** implement semantic-release-monorepo for proper versioning of sub-packages ([96c6284](https://github.com/drivecore/mycoder/commit/96c62848fbc3a4c1c591f3fd6202486e6461c4f2))
+- update hierarchical configuration system to fix failing tests ([93d949c](https://github.com/drivecore/mycoder/commit/93d949c03b7ebe96bad36713f6476c38d2a35224))
 
 ### Features
 
-* add --githubMode and --userPrompt as boolean CLI options that override config settings ([0390f94](https://github.com/drivecore/mycoder/commit/0390f94651e40de93a8cb9486a056a0b9cb2e165))
-* add CLI options for automated usage scenarios ([00419bc](https://github.com/drivecore/mycoder/commit/00419bc3e060db6d0c18fc72e2d7b6957791c875))
-* add maxTokens and temperature config options to CLI ([b461d3b](https://github.com/drivecore/mycoder/commit/b461d3b71b686d7679ecac62c0c66cc5a1df8fec)), closes [#118](https://github.com/drivecore/mycoder/issues/118)
-* implement hierarchical configuration system ([84d73d1](https://github.com/drivecore/mycoder/commit/84d73d1e6324670890a203f455fe257aeb6ed07a)), closes [#153](https://github.com/drivecore/mycoder/issues/153)
-* remove modelProvider and modelName - instant decrepation ([59834dc](https://github.com/drivecore/mycoder/commit/59834dcf932051a5c75624bd6f6ab12254f43769))
+- add --githubMode and --userPrompt as boolean CLI options that override config settings ([0390f94](https://github.com/drivecore/mycoder/commit/0390f94651e40de93a8cb9486a056a0b9cb2e165))
+- add CLI options for automated usage scenarios ([00419bc](https://github.com/drivecore/mycoder/commit/00419bc3e060db6d0c18fc72e2d7b6957791c875))
+- add maxTokens and temperature config options to CLI ([b461d3b](https://github.com/drivecore/mycoder/commit/b461d3b71b686d7679ecac62c0c66cc5a1df8fec)), closes [#118](https://github.com/drivecore/mycoder/issues/118)
+- implement hierarchical configuration system ([84d73d1](https://github.com/drivecore/mycoder/commit/84d73d1e6324670890a203f455fe257aeb6ed07a)), closes [#153](https://github.com/drivecore/mycoder/issues/153)
+- remove modelProvider and modelName - instant decrepation ([59834dc](https://github.com/drivecore/mycoder/commit/59834dcf932051a5c75624bd6f6ab12254f43769))
 
 # mycoder
 

packages/cli/COMMIT_CONVENTION.md

@@ -51,4 +51,3 @@ Commit messages are used to:
 1. Automatically determine the next version number
 2. Generate changelog entries
 3. Create GitHub releases
-

packages/cli/src/commands/config.ts

@@ -1,3 +1,5 @@
+import * as path from 'path';
+
 import chalk from 'chalk';
 import { Logger } from 'mycoder-agent';
 
@@ -8,6 +10,7 @@ import {
   updateConfig,
   getConfigAtLevel,
   clearConfigAtLevel,
+  clearConfigKey,
   ConfigLevel,
 } from '../settings/config.js';
 import { nameToLogIndex } from '../utils/nameToLogIndex.js';
@@ -18,7 +21,9 @@ export interface ConfigOptions extends SharedOptions {
   command: 'get' | 'set' | 'list' | 'clear';
   key?: string;
   value?: string;
-  all?: boolean;
+  all: boolean; // Has default value in builder, so it's always defined
+  global: boolean; // Has default value in builder, so it's always defined
+  verbose: boolean; // Has default value in builder, so it's always defined
 }
 
 export const command: CommandModule<SharedOptions, ConfigOptions> = {
@@ -45,6 +50,18 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
         type: 'boolean',
         default: false,
       })
+      .option('global', {
+        alias: 'g',
+        describe: 'Use global configuration instead of project-level',
+        type: 'boolean',
+        default: false,
+      })
+      .option('verbose', {
+        alias: 'v',
+        describe: 'Show detailed information including config file paths',
+        type: 'boolean',
+        default: false,
+      })
       .example('$0 config list', 'List all configuration values')
       .example(
         '$0 config get githubMode',
@@ -117,15 +134,15 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
       // Import directly to avoid circular dependency
       const { getSettingsDir } = await import('../settings/settings.js');
       const { getProjectConfigFile } = await import('../settings/config.js');
-      
+
       const globalConfigFile = path.join(getSettingsDir(), 'config.json');
       const projectConfigFile = getProjectConfigFile();
-      
+
       logger.info('Current configuration:');
       logger.info(`Global config file: ${globalConfigFile}`);
       logger.info(`Project config file: ${projectConfigFile}`);
       logger.info('');
-      
+
       const defaultConfig = getDefaultConfig();
 
       // Get all valid config keys
@@ -287,15 +304,8 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
         return;
       }
 
-      // Get the current config, create a new object without the specified key
-      const currentConfig = getConfig();
-      const { [argv.key]: _, ...newConfig } = currentConfig as Record<
-        string,
-        any
-      >;
-
-      // Update the config file with the new object
-      updateConfig(newConfig);
+      // Clear the specified key from the configuration at the current level
+      clearConfigKey(argv.key, configLevel);
 
       // Get the default value that will now be used
       const defaultValue =
@@ -308,13 +318,23 @@ export const command: CommandModule<SharedOptions, ConfigOptions> = {
       // Determine where the new value is coming from
       const isDefaultAfterClear =
         JSON.stringify(newValue) === JSON.stringify(defaultValue);
+
+      // Get the actual config values at each level
+      const globalConfig = getConfigAtLevel(ConfigLevel.GLOBAL);
+      const projectConfig = getConfigAtLevel(ConfigLevel.PROJECT);
+
+      // Check if key exists AND has a non-default value in each level
       const afterClearInGlobal =
         !isDefaultAfterClear &&
-        argv.key in getConfigAtLevel(ConfigLevel.GLOBAL);
+        argv.key in globalConfig &&
+        JSON.stringify(globalConfig[argv.key]) !== JSON.stringify(defaultValue);
+
       const afterClearInProject =
         !isDefaultAfterClear &&
         !afterClearInGlobal &&
-        argv.key in getConfigAtLevel(ConfigLevel.PROJECT);
+        argv.key in projectConfig &&
+        JSON.stringify(projectConfig[argv.key]) !==
+          JSON.stringify(defaultValue);
 
       let sourceDisplay = '';
       if (isDefaultAfterClear) {

packages/cli/src/index.ts

@@ -13,6 +13,7 @@ import { command as toolsCommand } from './commands/tools.js';
 import { sharedOptions } from './options.js';
 import { initSentry, captureException } from './sentry/index.js';
 import { getConfig } from './settings/config.js';
+import { cleanupResources, setupForceExit } from './utils/cleanup.js';
 import { enableProfiling, mark, reportTimings } from './utils/performance.js';
 
 mark('After imports');
@@ -82,4 +83,11 @@ await main()
   .finally(async () => {
     // Report timings if profiling is enabled
     await reportTimings();
+
+    // Clean up all resources before exit
+    await cleanupResources();
+
+    // Setup a force exit as a failsafe
+    // This ensures the process will exit even if there are lingering handles
+    setupForceExit(5000);
   });

packages/cli/src/settings/config.ts

@@ -23,7 +23,7 @@ const globalConfigFile = path.join(getSettingsDir(), 'config.json');
 // Export for testing
 export const getProjectConfigFile = (): string => {
   const projectDir = getProjectSettingsDir();
-  
+
   // Ensure the project directory exists
   if (projectDir && !fs.existsSync(projectDir)) {
     try {
@@ -33,7 +33,7 @@ export const getProjectConfigFile = (): string => {
       return '';
     }
   }
-  
+
   return projectDir ? path.join(projectDir, 'config.json') : '';
 };
 
@@ -286,9 +286,17 @@ export const clearConfigKey = (
   }
 
   // Create a new config without the specified key
-  const { [key]: _, ...newConfig } = currentLevelConfig as Record<string, any>;
+  const { [key]: removedValue, ...newConfig } = currentLevelConfig as Record<
+    string,
+    any
+  >;
+  console.log(`Removed value for key ${key}:`, removedValue);
 
   // Write the updated config back to the file
+  console.log(`Clearing key ${key} from ${targetFile}`);
+  console.log(`Original config:`, JSON.stringify(currentLevelConfig, null, 2));
+  console.log(`New config without key:`, JSON.stringify(newConfig, null, 2));
+
   fs.writeFileSync(targetFile, JSON.stringify(newConfig, null, 2));
 
   // Return the new merged configuration

packages/cli/src/settings/settings.ts

@@ -34,7 +34,7 @@ export const getProjectSettingsDir = (): string => {
 
   // If we're creating a new project config, use the current directory
   const projectDir = path.join(process.cwd(), '.mycoder');
-  
+
   // Ensure directory exists when it's requested
   if (!fs.existsSync(projectDir)) {
     try {
@@ -45,7 +45,7 @@ export const getProjectSettingsDir = (): string => {
       // as other code will handle the error when trying to use it
     }
   }
-  
+
   return projectDir;
 };