Fix double yargs initialization in CLI profiling feature #102
+14
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Double Yargs Initialization in CLI Profiling Feature
This PR fixes an issue in PR #101 where yargs was being initialized twice in the main function. This double initialization was done to check for the profiling flag early, but it's inefficient and could cause problems.
Changes
Modified the
performance.ts
module to always collect timing data regardless of whether profiling is enabledRemoved the early yargs initialization in the main function
Updated tests to reflect the changes
Related Issues
Fixes part of #100 (CLI startup performance issues)
Should be merged into PR #101
Testing
All functionality of the profiling feature remains intact, but the implementation is now more efficient.