Skip to content

Conversation

bhouston
Copy link
Member

@bhouston bhouston commented Mar 6, 2025

Description

This PR enhances the pre-commit hooks to include build and test checks, preventing commits that would break the build or fail tests.

Changes

  • Updated the pre-commit hook to run pnpm build and pnpm test before allowing commits
  • Updated the CONTRIBUTING.md documentation to reflect these changes

Testing

  • Tested the pre-commit hook locally to ensure it correctly prevents commits when builds fail or tests don't pass
  • Confirmed that the hook allows commits when all checks pass

Related Issues

Fixes #122

Note

There's a Husky deprecation warning about the shebang and source line that will need to be addressed in a future update when upgrading to Husky v10.0.0.

@bhouston bhouston merged commit 32164b3 into main Mar 6, 2025
1 check passed
@bhouston bhouston deleted the feature/122-pre-commit-build-test-checks branch March 12, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add build and test checks to pre-commit hooks

1 participant