Skip to content

Conversation

bhouston
Copy link
Member

This PR addresses issue #227 by removing duplicated model properties from AgentConfig and relying solely on ToolContext for them.

Changes

  • Removed provider, model, maxTokens, and temperature from AgentConfig
  • Added maxTokens and temperature to ToolContext (which already had provider and model)
  • Updated toolAgent function to use these properties from ToolContext instead of AgentConfig
  • Updated DEFAULT_CONFIG to remove these properties
  • Updated all code that uses AgentConfig to get these properties from ToolContext
  • Updated tests to include the required properties in mock contexts

This change simplifies the codebase and removes confusion about where these configuration values should be set.

@bhouston bhouston merged commit 0654722 into main Mar 12, 2025
1 check passed
Copy link

🎉 This PR is included in version mycoder-agent-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version mycoder-v1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant