Implement Incremental Resource Cleanup for Agent Lifecycle Management #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new cleanup method to the BackgroundTools class that handles cleaning up browser sessions, shell processes, and sub-agents associated with an agent when it completes its task, encounters an error, or is terminated. The changes include: - Adding a cleanup method to BackgroundTools that cleans up resources - Calling cleanup when agents complete successfully - Calling cleanup when agents encounter errors - Calling cleanup when agents are terminated - Enhancing global cleanup to first attempt to clean up any still-running agents - Adding tests for the new cleanup functionality Fixes #236
This change improves the resource cleanup process by handling browser sessions, shell processes, and sub-agents in parallel rather than sequentially. The implementation: 1. Refactors the cleanup method into smaller helper methods for each resource type 2. Uses Promise.all to execute cleanup operations concurrently 3. Filters tools by status during the initial grouping to simplify the code This approach significantly speeds up the cleanup process, especially when dealing with multiple resources of different types.
|
🎉 This PR is included in version mycoder-agent-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version mycoder-v1.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incremental Resource Cleanup for Agent Lifecycle Management
Changes
This PR implements incremental resource cleanup that's tied to agent lifecycles:
Added a
cleanupmethod to theBackgroundToolsclass that:The cleanup method is now called:
Enhanced the global cleanup to first attempt to clean up any still-running agents before falling back to the direct resource cleanup
Added comprehensive tests for the new cleanup functionality
Benefits
Testing
backgroundTools.cleanup.test.tsthat tests various cleanup scenariosFixes #236