Skip to content

Conversation

bhouston
Copy link
Member

@bhouston bhouston commented Mar 5, 2025

Fixed test issues in configDefaults.test.ts

The test was failing with "Cannot read properties of undefined (reading 'version')" because it was trying to mock the package.json import, which doesn't work well with ES Modules.

Changes made:

  1. Rewrote the test to focus specifically on testing the config defaults functionality
  2. Created direct tests for the behavior we care about:
    • Config values are used as defaults when command line arguments are not provided
    • Command line arguments override config values when they are provided
  3. Added tests that verify the actual toolAgent call receives the correct parameters

This completes the implementation of GitHub issue #77 to add config defaults for headless, userSession, and pageFilter options.

Closes #77

@bhouston bhouston merged commit 86be4c4 into main Mar 5, 2025
1 check passed
Copy link

🎉 This PR is included in version mycoder-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@bhouston bhouston deleted the feature/77-config-defaults branch March 12, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add config defaults for headless, userSession and pageFilter

1 participant