Skip to content

Conversation

@pjbull
Copy link
Member

@pjbull pjbull commented Jul 21, 2025

Azure SDK typing indicates return type ItemPaged[BlobProperties | BlobPrefix] for walk_blobs.

Per this issue, BlobPrefix is only returned if the delimiter kwarg is passed. Since we do not do that, we can safely ignore the typing issue and both walk_blobs and list_blobs will return ItemPaged[BlobProperties] as we expect.

Closes #523

@github-actions
Copy link
Contributor

@github-actions github-actions bot temporarily deployed to pull request July 21, 2025 15:30 Inactive
@codecov
Copy link

codecov bot commented Jul 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.4%. Comparing base (65c5c01) to head (342b0f1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #524     +/-   ##
========================================
- Coverage    93.5%   93.4%   -0.2%     
========================================
  Files          23      23             
  Lines        1800    1800             
========================================
- Hits         1684    1682      -2     
- Misses        116     118      +2     
Files with missing lines Coverage Δ
cloudpathlib/azure/azblobclient.py 91.9% <100.0%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pjbull pjbull merged commit 863e884 into master Jul 21, 2025
25 checks passed
@pjbull pjbull deleted the typing-test-failure branch July 21, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed build: tests

2 participants