This repository was archived by the owner on Feb 22, 2020. It is now read-only.

Improve various code styles#309

Merged

isms merged 23 commits intomasterfrom

lamby/wip/code-style

Mar 1, 2018

Commits on Feb 27, 2018

No need for lists; prefer tuples as they imply we can't/won't change them later undeneath you.
lamby
committed
Tidy """-style docstrings, moving everything to a vaguely-consistent style.
lamby
committed
Tidy code style around imports.
lamby
committed
Reflow indentation to prevent unnecessary VCS diff noise on future changes.
lamby
committed
Import os.path.{join,dirname,abspath} directly instead of importing `path` from os.path. This is more Pythonic.
lamby
committed
Import "batteries-included" modules as top-level, ie. without using `from`.
lamby
committed
Drop unnecessary parenthesis.
lamby
committed
Use [] and {} to generate empty lists and dictionaries over list() and dict().
lamby
committed
Use `os.path.join` over constructing paths ourselves.
lamby
committed
Drop print() statement.
lamby
committed
Avoid aliasing __builtins__.
lamby
committed
Define `config` dicts in one go, instead of poking things into them after creating one.
lamby
committed
Make it clearer that `sizelim` is a float; "6." is not very obvious!
lamby
committed
Prefer single quotes over double quotes; the former expresses better that this is "computer" text versus "human" text.
lamby
committed
Drop unnecessary parenthesis.
lamby
committed
Use the `exist_ok` keyword argument when calling `os.makedirs` instead of testing the directory exists first.
lamby
committed
Use more Pythonic `num_X` variable names over `num_of_X` or `X_count`.
lamby
committed
Improve code spacing variously for readability.
lamby
committed
Use str.format over interpolation with '%'.
lamby
committed
Drop weird/misleading/commented-out code.
lamby
committed
Tidy "inline" comments.
lamby
committed
Cleanup/remove some unnecessary control-flow statement around unconditional control-flow.
lamby
committed
Prevent a long line warning.
lamby
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve various code styles#309

Improve various code styles#309
isms merged 23 commits intomasterfrom
lamby/wip/code-style

Commits on Feb 27, 2018

No need for lists; prefer tuples as they imply we can't/won't change them later undeneath you.

Tidy """-style docstrings, moving everything to a vaguely-consistent style.

Tidy code style around imports.

Reflow indentation to prevent unnecessary VCS diff noise on future changes.

Import os.path.{join,dirname,abspath} directly instead of importing `path` from os.path. This is more Pythonic.

Import "batteries-included" modules as top-level, ie. without using `from`.

Drop unnecessary parenthesis.

Use [] and {} to generate empty lists and dictionaries over list() and dict().

Use `os.path.join` over constructing paths ourselves.

Drop print() statement.

Avoid aliasing builtins.

Define `config` dicts in one go, instead of poking things into them after creating one.

Make it clearer that `sizelim` is a float; "6." is not very obvious!

Prefer single quotes over double quotes; the former expresses better that this is "computer" text versus "human" text.

Drop unnecessary parenthesis.

Use the `exist_ok` keyword argument when calling `os.makedirs` instead of testing the directory exists first.

Use more Pythonic `num_X` variable names over `num_of_X` or `X_count`.

Improve code spacing variously for readability.

Use str.format over interpolation with '%'.

Drop weird/misleading/commented-out code.

Tidy "inline" comments.

Cleanup/remove some unnecessary control-flow statement around unconditional control-flow.

Prevent a long line warning.