feat(design-system): add autocomplete [AR-38986] #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/design-system/src/components/ds-avatar-group/ds-avatar-group.module.scss
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.types.tsx
Outdated
Show resolved
Hide resolved
| /** | ||
| * Label to display in the autocomplete dropdown | ||
| */ | ||
| label: string; |
Collaborator
There was a problem hiding this comment.
Do we want to allow to pass ReactNode? Fallback for some fancy design
Collaborator
Author
There was a problem hiding this comment.
there is no requirement for it
it will require custom handling and inceasing scope of work for implementation
| /** | ||
| * Value to return when the option is selected | ||
| */ | ||
| value: string; |
Collaborator
There was a problem hiding this comment.
string feels too limited. Very often even specific object type can be a value.
I try would go with some generic type, it should work, right?
type DefaultValue = string | number;
export interface DsAutocompleteOption <T = DefaultValue> {
//...
What do you think? 🤔
Collaborator
Author
There was a problem hiding this comment.
I would prefer to stay with current simple implementation and delegate data preparation logic to component consumer
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.types.tsx
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.stories.tsx
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Outdated
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Show resolved
Hide resolved
packages/design-system/src/components/ds-autocomplete/ds-autocomplete.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.