Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates repository metadata and CI configuration following a repository ownership transfer from ZR233 to drivercraft.
Changes:
- Updated repository URLs from
github.com/ZR233/ostooltogithub.com/drivercraft/ostoolacross all package manifests - Removed
documentationandreadmefields from some Cargo.toml files to rely on defaults - Added a new
release-plz-prjob in the release workflow with YAML anchors for code reuse
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uboot-shell/Cargo.toml | Updated repository URL; removed documentation and readme fields |
| ostool/Cargo.toml | Updated repository URL; removed documentation field while keeping readme |
| jkconfig/Cargo.toml | Updated repository URL; removed documentation and readme fields |
| fitimage/Cargo.toml | Updated repository URL; removed documentation and readme fields |
| .github/workflows/release.yml | Added release-plz-pr job with YAML anchors; updated checkout action to v6 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| uses: actions/checkout@v4 | ||
| - &checkout | ||
| name: Checkout repository | ||
| uses: actions/checkout@v6 |
There was a problem hiding this comment.
The checkout action is updated to v6 in the new job steps, but the existing 'build-binaries' job still uses v4 (line 70). For consistency, all checkout actions in the workflow should use the same version. Consider updating line 70 to also use v6, or verify that v6 is the intended version for this workflow.
| uses: actions/checkout@v6 | |
| uses: actions/checkout@v4 |
| name: Install Rust toolchain | ||
| uses: dtolnay/rust-toolchain@stable | ||
|
|
||
| - &setup-libudenv: |
There was a problem hiding this comment.
The anchor name has a syntax error. It should be 'setup-libudev' (without the colon), not 'setup-libudenv:'. YAML anchor definitions should not end with a colon. This will cause the workflow to fail.
| steps: | ||
| - *checkout | ||
| - *install-rust | ||
| - *setup-libudenv |
There was a problem hiding this comment.
The anchor name has a typo: 'setup-libudenv' should be 'setup-libudev' (missing 'd' in 'udev'). This should match the corrected anchor definition on line 29.
| - *checkout | ||
| - *install-rust | ||
| - *setup-libudenv |
There was a problem hiding this comment.
GitHub Actions YAML anchors can only be referenced within the same job. The anchors defined in the 'release-plz' job (lines 19, 25, 29) cannot be referenced in a different job ('release-plz-pr'). Each job needs to define its own steps explicitly or redefine the anchors.
| - *checkout | |
| - *install-rust | |
| - *setup-libudenv | |
| - name: Checkout repository | |
| uses: actions/checkout@v6 | |
| with: | |
| fetch-depth: 0 | |
| persist-credentials: false | |
| - name: Install Rust toolchain | |
| uses: dtolnay/rust-toolchain@stable | |
| - uses: awalsh128/cache-apt-pkgs-action@latest | |
| with: | |
| packages: libudev-dev | |
| version: 1.0 |
1 participant
No description provided.