Skip to content

02 ternary v4 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RomanMokych wants to merge 22 commits into
base: master
Choose a base branch
from
Open

02 ternary v4 #30

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6423a44
Fixed build issues. Fixed linking with gtest. Added dependecy on gtes…
RomanMokych Oct 26, 2018
4919240
Added build files to the git ignore.
RomanMokych Oct 26, 2018
f842648
Disabled 6 homework because it is not buildable.
RomanMokych Nov 7, 2018
1b97594
Implemented one parsing. RED.
RomanMokych Nov 7, 2018
96d8352
Implemented one parsing. Green.
RomanMokych Nov 7, 2018
4d8bebe
Implemented 2 parsing. RED
RomanMokych Nov 7, 2018
6872951
Implemented 2 parsing. GREEN
RomanMokych Nov 7, 2018
5d0f54a
Implemented 3 parsing. Green
RomanMokych Nov 7, 2018
37784bb
Implemented 6 parsing. Red
RomanMokych Nov 7, 2018
a745777
Implemented test for 6 parsing. Green
RomanMokych Nov 7, 2018
a97fb14
Implemented RED test for 9.
RomanMokych Nov 7, 2018
089d2cd
GREEN
RomanMokych Nov 7, 2018
9b3bfa7
Refactoring.
RomanMokych Nov 7, 2018
ffc9478
Implemented RED test for 4
RomanMokych Nov 7, 2018
537bc43
GREEN
RomanMokych Nov 7, 2018
508581e
Implemented red test for '111'.
RomanMokych Nov 7, 2018
65468fa
GREEN
RomanMokych Nov 7, 2018
8eaaa63
Refactoring.
RomanMokych Nov 7, 2018
a058bd3
Added acceptance test.
RomanMokych Nov 7, 2018
7b4d5d0
Implemented RED test for invalid ternary.
RomanMokych Nov 7, 2018
65e138f
GREEN
RomanMokych Nov 7, 2018
8886455
Extended test for invalid ternary.
RomanMokych Nov 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tdd_intro/homework/02_ternary_numbers/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ int IntFromTernaryNumberString(const std::string& ternaryNumberString)
return (ternaryNumberString.front() - '0') * 3;
}

return ternaryNumberString.back() - '0';
Copy link
Collaborator

@mettizik mettizik Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не совсем понял с чем связано это изменение на этапе красного теста

return ternaryNumberString.front() - '0';
Copy link
Collaborator

@mettizik mettizik Nov 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

как только ты добавляешь front() или back() сразу стоит задуматься о тесте с пустой строкой :)

}

TEST(IntFromTernaryNumberString, one)
Expand All @@ -48,3 +48,9 @@ TEST(IntFromTernaryNumberString, decimal6ForTernary20)
{
EXPECT_EQ(6, IntFromTernaryNumberString("20"));
}

TEST(IntFromTernaryNumberString, decimal9ForTernary100)
{
EXPECT_EQ(9, IntFromTernaryNumberString("100"));
}