Skip to content

04 weather client #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Magzimga wants to merge 9 commits into
base: master
Choose a base branch
from
Open

04 weather client #40

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
925a4be
small test list, and request test became green
Magzimga Nov 23, 2018
4e35234
Tested client sends 4 requests for a day with correct times. Refactored
Magzimga Nov 23, 2018
9e8060d
Client calls server: Checked other client methods
Magzimga Nov 23, 2018
b17c2fe
refactoring
Magzimga Nov 23, 2018
5616e93
Weather parsing. First test
Magzimga Nov 23, 2018
ef583e3
Test for minimum temperature as it is simple to calculate
Magzimga Nov 23, 2018
aaeb67e
build fix
Magzimga Nov 23, 2018
483fe89
average temperature. Without refactoring
Magzimga Nov 23, 2018
ca04b5a
Temperature is covered with tests
Magzimga Nov 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 46 additions & 4 deletions tdd_intro/homework/04_weather_client/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,9 @@ class FakeWeatherServer : public IWeatherServer

std::vector<std::string> GetRequests()
{
return m_requests;
std::vector<std::string> result;
result.swap(m_requests);
return result;
}
};

Expand All @@ -149,9 +151,21 @@ class WeatherClient : public IWeatherClient
GetWeatherForADay(server, date);
return 0.0;
}
virtual double GetMaximumTemperature(IWeatherServer& server, const std::string& date){return 0.0;}
virtual double GetAverageWindDirection(IWeatherServer& server, const std::string& date){return 0.0;}
virtual double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date){return 0.0;}
virtual double GetMaximumTemperature(IWeatherServer& server, const std::string& date)
{
GetWeatherForADay(server, date);
return 0.0;
}
virtual double GetAverageWindDirection(IWeatherServer& server, const std::string& date)
{
GetWeatherForADay(server, date);
return 0.0;
}
virtual double GetMaximumWindSpeed(IWeatherServer& server, const std::string& date)
{
GetWeatherForADay(server, date);
return 0.0;
}
private:
std::vector<std::string> GetWeatherForADay(IWeatherServer& server, const std::string& date)
{
Expand Down Expand Up @@ -188,3 +202,31 @@ TEST(WeatherClient, ClientSends4TimesForMinTemp)
client.GetMinimumTemperature(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());
}
TEST(WeatherClient, FourRequestsForAnyClientCall)
Copy link
Collaborator

@mettizik mettizik Nov 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

это должны были быть раздельные тесты)

{
std::vector<std::string> expectedRequests =
{
CreateRequest(s_testDate,s_3hours),
CreateRequest(s_testDate,s_9hours),
CreateRequest(s_testDate,s_15hours),
CreateRequest(s_testDate,s_21hour)
};
WeatherClient client;
FakeWeatherServer server;

client.GetAverageTemperature(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());

client.GetMaximumTemperature(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());

client.GetAverageWindDirection(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());

client.GetAverageWindDirection(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());

client.GetMaximumWindSpeed(server, s_testDate);
ASSERT_EQ(expectedRequests, server.GetRequests());

}