fix: add quotes to all excluded column references in upsert guide #627
+8
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user uses any column names with capital letters (e.g. columnName...) if they copy the code in the upsert guide they'll run into a confusing error: column excluded.columnname does not exist This is because without the quotes the db will treat the name as all lowercase. The commit adds quotes to all usages of excluded, even if not strictly required for the examples. See drizzle-team/drizzle-orm#675
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user uses any column names with capital letters (e.g. columnName...) if they copy the code in the upsert guide they'll run into a confusing error:
column excluded.columnname does not exist
This is because without the quotes the db will treat the name as all lowercase.
The commit adds quotes to all usages of excluded, even if not strictly required for the examples.
See drizzle-team/drizzle-orm#675