Fix zod/v4 uuid compatibility #4868
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when will this be merged? |
Waiting for it as well |
Collaborator
|
Hi @KorvinSzanto. Thank you for your work on this pull request. I’ve opened a PR (#4222) to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler fix than described in the UUID discussion and implemented in #4503 serving to hopefully be an easier thing to merge. This works by changing the 4th group to start with a valid number.
This change has the same issue as #4503 in that it leads to changed UUIDs given an existing seed, but the alternative here would be to add a flag to the
seedoptions and that seems overly cumbersome.Resolves #4551