fix(drizzle-zod): use dataType for Buffer type detection #5192
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change type-level condition from 'TColumn["_"]["data"] extends Buffer' to 'TColumn["_"]["dataType"] extends "buffer"' to align with runtime implementation and prevent incorrect type inference in certain environments. Fixes drizzle-team#4705
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4705
Problem
The type-level condition
TColumn['_']['data'] extends Buffercan produce false positives in environments where theBuffertype is declared differently (e.g. Cloudflare Workers), causing non-buffer columns to be inferred asBuffer.Solution
Switch the check to
TColumn['_']['dataType'] extends 'buffer'to match the runtime logic that treatsdataType === 'buffer'as a Buffer column.Testing
Acknowledgments
Thanks to @stefnba for testing and confirming this fix works in a Hono + React (Vite) setup:
#4705 (comment)