fix(drizzle-kit): fix silent failure when schema has duplicate entities #5264
+41
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmrEsyd
force-pushed
the
fix/silent-schema-errors
branch
from
b15f570 to
29f2262
Compare
- Fixed wrong variable (errors vs errors2) being logged in error handlers - postgres/serializer.ts: errors -> errors2 - cockroach/serializer.ts: errors -> errors2 - generate-mssql.ts: errors -> errors2 - push-mssql.ts: errors -> errors1/errors2 - Added missing error type handlers in postgresSchemaError(): - table_name_duplicate - column_name_duplicate - schema_name_duplicate - enum_name_duplicate - enum_values_duplicate - role_duplicate - privilege_duplicate
AmrEsyd
force-pushed
the
fix/silent-schema-errors
branch
from
29f2262 to
b1b1624
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed wrong variable (errors vs errors2) being logged in error handlers
Added missing error type handlers in postgresSchemaError():
Closes [BUG]: drizzle-kit generate silently exits with code 1 #5263