ci(turbo): use $TURBO_ROOT$ for root file references and add transit node #5286
+60
−252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… node - Replace '../tsconfig.json' and '../README.md' with '$TURBO_ROOT$/tsconfig.json' and '$TURBO_ROOT$/README.md' across all package build tasks - Add transit node task to enable parallel execution of test:types while maintaining correct cache invalidation - Change test:types to depend on transit instead of ^test:types for better parallelization
Reduces config from 192 to 58 lines by using a base 'build' task that defines common inputs/outputs. Package-specific tasks only override dependsOn when needed.
anthonyshew
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
../tsconfig.json,../README.md) with$TURBO_ROOT$references in all package build task inputstransittask to enable parallel execution oftest:typeswhile maintaining correct cache invalidationWhy
$TURBO_ROOT$references: Using../to traverse out of a package ininputsis an anti-pattern in Turborepo. The$TURBO_ROOT$variable is the recommended way to reference files at the repository root, providing clearer intent and better compatibility with Turborepo's internals.Transit node: The
test:typestask previously useddependsOn: ["^test:types", ...]which forces sequential execution across packages. However, type checking doesn't need built output from dependencies - it only needs the source types. The transit node pattern creates the dependency graph relationship for correct cache invalidation without forcing sequential execution, allowingtest:typestasks to run in parallel.Notes
buildhas been collapsed into one definition. There were some nuances that the LLM appears to have taken care of, and I've reviewed carefully - but I am paranoid that I may have missed something.