feat: deduplicate parameters in postgres#5400
Open
sakulstra wants to merge 1 commit intodrizzle-team:betafrom
Open
feat: deduplicate parameters in postgres#5400sakulstra wants to merge 1 commit intodrizzle-team:betafrom
sakulstra wants to merge 1 commit intodrizzle-team:betafrom
Conversation
sakulstra
force-pushed
the
feat/dedupe-params
branch
from
caf07ba to
074ca79
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Postgres has max params of
65534, which can be quite annoying on batch inserts, but postgres also allows reusing parameters. So an insert inserting 10 rows, with 5 equal columns could use 5 params instead of 50 params.As I think most other dialects enforce ordered params, i added a map for deduplication exclusively on the postgres dialect.
targeted beta as we're using beta, let me know if that was wrong