Polish codebase: fix panics, check errors, reduce duplication#235
Merged
Conversation
- Add bounds checking in battery-percent, cpu, tmux-status/right, openweather, and wttr to prevent panics on unexpected input - Check ignored errors from json.Unmarshal, os.WriteFile, cfg.SaveTo, and cobra Execute() across gmail, slack, tts, and config packages - Extract shared printJSON to pkg/jsonutil, duplicate capture() to pkg/run.CaptureClean, and consolidate link.Soft/Hard into shared helper - Unify component registry: single source of truth in install.Components() eliminates duplicate lists in install.go and install/root.go - Consolidate spotify token exchange and extract API URL constants - Replace os.Exit(0) in cache.Log with bool return for testability - Remove unused Color/Separator types, fix byte-vs-rune slicing in ssid - Move git-ancestor package-level vars into main(), use const Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean code analysis and refactoring across 31 files:
Co-Authored-By: Claude noreply@anthropic.com