Skip to content

Migrated build.gradle to accept project-wide properties #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Migrated build.gradle to accept project-wide properties #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
856916e
Update build.gradle to accept android tools versions
mthahzan Jul 3, 2019
8430086
Replaced deprecated compile statements
mthahzan Jul 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,25 @@
apply plugin: "com.android.library"

def safeExtGet(prop, fallback) {
rootProject.ext.has(prop) ? rootProject.ext.get(prop) : fallback
}

android {
compileSdkVersion 25
buildToolsVersion "25.0.1"
compileSdkVersion safeExtGet('compileSdkVersion', 25)
buildToolsVersion safeExtGet('buildToolsVersion', "25.0.1")

defaultConfig {
minSdkVersion 16
targetSdkVersion 23
versionCode 1
versionName "1.0"
minSdkVersion safeExtGet('minSdkVersion', 16)
targetSdkVersion safeExtGet('targetSdkVersion', 27)
}
}

dependencies {
compile "com.facebook.react:react-native:+" // From node_modules
compile 'com.android.support:customtabs:25.0.1'
compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') {
implementation "com.facebook.react:react-native:+" // From node_modules
implementation "com.android.support:customtabs:${safeExtGet('supportLibVersion', '25.0.1')}"
implementation ('com.github.droibit.customtabslauncher:launcher:1.0.8') {
exclude module: 'customtabs'
}

testCompile 'junit:junit:4.12'
}
testImplementation 'junit:junit:4.12'
}