Skip to content

fix: android build error , matching androidx implementation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix: android build error , matching androidx implementation #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59378e1
update: build gradle
Chimaa123 Oct 16, 2023
5709a41
fix: android build
Chimaa123 Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,19 @@
apply plugin: "com.android.library"

android {
compileSdkVersion 25
buildToolsVersion "25.0.1"
compileSdkVersion rootProject.ext.hasProperty('compileSdkVersion') ? rootProject.ext.compileSdkVersion : 33
buildToolsVersion rootProject.ext.hasProperty('buildToolsVersion') ? rootProject.ext.buildToolsVersion : "33.0.0"

defaultConfig {
minSdkVersion 16
targetSdkVersion 23
minSdkVersion rootProject.ext.hasProperty('minSdkVersion') ? rootProject.ext.minSdkVersion : 23
targetSdkVersion rootProject.ext.hasProperty('targetSdkVersion') ? rootProject.ext.targetSdkVersion : 33
versionCode 1
versionName "1.0"
}
}

dependencies {
compile "com.facebook.react:react-native:+" // From node_modules
compile 'com.android.support:customtabs:25.0.1'
compile ('com.github.droibit.customtabslauncher:launcher:1.0.8') {
exclude module: 'customtabs'
}

testCompile 'junit:junit:4.12'
}
implementation 'com.facebook.react:react-native:+'
implementation 'androidx.browser:browser:1.5.0'
implementation 'com.github.droibit.customtabslauncher:launcher:1.0.8'
}
4 changes: 2 additions & 2 deletions ...oid/src/main/java/com/github/droibit/android/reactnative/customtabs/CustomTabsModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import android.content.Intent;
import android.os.Bundle;
import android.provider.Browser;
import android.support.customtabs.CustomTabsIntent;
import androidx.browser.customtabs.CustomTabsIntent;
import android.text.TextUtils;

import com.droibit.android.customtabs.launcher.CustomTabsLauncher;
Expand Down Expand Up @@ -180,7 +180,7 @@ public void openURL(String url, ReadableMap option, Promise promise) {
customTabsIntent.intent.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
customTabsIntent.intent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
}

return customTabsIntent;
}

Expand Down