Skip to content

修复在多模块java项目中，并行打包镜像时，镜像因为同名称被覆盖的问题 #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

修复在多模块java项目中，并行打包镜像时，镜像因为同名称被覆盖的问题 #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d41b50e
修复在多模块java项目中，并行打包镜像时，镜像因为同名称被覆盖的问题
Sep 9, 2022
173f535
Update README.md
mailbyms Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@

Drone plugin uses Docker-in-Docker to build and publish Docker images to a container registry. For the usage information and a listing of the available options please take a look at [the docs](http://plugins.drone.io/drone-plugins/drone-docker/).

## 修改记录
修复如下问题：
1. 当一个多模块java项目中，会产生多个 jar 包，并分别打包镜像时，镜像因为同名称被覆盖的问题
2. 问题在于，原官方代码，使用 docker -t {commit.sha} -f xxx {context } 这样的格式打包镜像，再 docker tag 为目标标签。导致在 drone 使用并行打包镜像时，各个模块都 -t {commit.sha} ，即镜像被覆盖
3. 解决方法：在 -t 后面的参数，改为 {commit.sha} + "/" + {"repo"} 。其实改为随机数 / UUID 都可以，只要保证它不重复即可

## Build

Build the binaries with the following commands:
Expand Down
2 changes: 1 addition & 1 deletion cmd/drone-docker/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ func run(c *cli.Context) error {
CardPath: c.String("drone-card-path"),
Build: docker.Build{
Remote: c.String("remote.url"),
Name: c.String("commit.sha"),
Name: c.String("commit.sha") + "/" + c.String("repo"),
Dockerfile: c.String("dockerfile"),
Context: c.String("context"),
Tags: c.StringSlice("tags"),
Expand Down