Skip to content

Conversation

@raphendyr
Copy link

The exec command doesn't respect environment variable DRONE_RUNNER_MAX_RPOCS. I think it would be better. However, I implemented this single flag for the configuration parameter, which was the only one without a command line argument.

@tphoney
Copy link

tphoney commented Jul 20, 2021

What was the situation that this was important ?

@raphendyr
Copy link
Author

raphendyr commented Jul 20, 2021

I have around 50 parallel steps, which (trivially) resulted Drone for mac to run out of memory. I'm using drone-runner-docker exec in place of drone exec as the runner has better set of features. Additionally, if the latter is expect to be replaced by the former, I felt that it's better to contribute here.

Any case, the exec should also respect the environment variable DRONE_RUNNER_MAX_RPOCS, which would be better. That was just way bigger change, so I didn't want to look into that.

Note that the limitation is implemented, the exec subcommand just didn't set the value for it, i.e., the code used the unchanged default from the struct.

@RopoMen
Copy link

RopoMen commented Apr 28, 2022

@tphoney what is status for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants