Feature: support minimum idle time before terminating server#125
Feature: support minimum idle time before terminating server#125tjstansell wants to merge 16 commits intodrone:masterfrom
Conversation
|
Hm... the above changes cause slack notifications to be sent since they trigger on Updates. |
|
@tjstansell conceptually I like the idea, however, the |
|
ok, reading the patch, I think I have a better understanding. It looks like a forced save is used to update the |
|
Thanks for all the feedback so far. I updated it to use a new LastBusy field to track this. Hopefully I did it right. :) Let me know if we need anything else. |
|
Actually, I think I now see how the db migration bits work ... working on updating it to do a proper migration. |
|
I deployed this to our internal instance and it seems to be working! Let me know if there's anything you'd like to see changed, though... Thanks! |
|
Any additional thoughts on this? Thanks. |
the autoscaler will shutdown any server that is not busy but has reached the min_age parameter (30m currently) This feature adds a new flag that basically resets the age to 0 every time a new build is executed. This will allow us to decrease the min-age but allow the servers to be used for a longer period of time during busy hours, thus avoiding starting up too many servers and decreasing the build startup times This is a feature added by a contributor to the original autoscaler code. harness is very slow to accept contributions so the PR has sat there for about 1 month. drone#125
|
@bradrydzewski curious if there's any way to get some progress on this so it doesn't just get lost. fwiw, we've been running on this code on our production instances for months now without any issue. |
|
@bradrydzewski sorry to keep pestering, but I've been trying to get some progress on this PR now for over 3 months with zero responses. Is there any chance someone can take a look at this before it's so stale it's no longer valid? |
|
It would be nice to have this feature merged |
…d by the slack notifier
tjstansell
force-pushed
the
min-idle
branch
from
8b5bc96 to
99ed3b3
Compare
|
FWIW, we've been running this patched version for the last year and a half and have not noticed any issues... I did just rebase my patch against the current master branch to pick up the other features that have been added, so this is now current. I'd love it if someone could evaluate this and hopefully merge it this time... |
|
is possible to merge this pr? |
4 participants
This attempts to add support for
DRONE_POOL_MIN_IDLE, which will define the minimum idle time before a server is terminated. It defaults to0, but if you set it to30mthen it will only terminate a server after it has sat idle for at least 30 minutes (no jobs have run). It utilizes theUpdatedserver property, which I believe gets updated as the server changes state fromrunningtopendingstatus. As it completes the builds, this should represent when the last build finished. As such, if jobs continue to fire regularly, then it stays online, but if jobs stop, it would then terminate after this duration.I'm currently trying to get a test installation online to test these changes, but figured I'd see if folks had feedback regardless.