Refactor check for branch to reduce possible regression

Author: christianruhstaller

scm/driver/bitbucket/linker.go

@@ -25,16 +25,15 @@ func (l *linker) Resource(ctx context.Context, repo string, ref scm.Reference) (
 	case scm.IsPullRequest(ref.Path):
 		d := scm.ExtractPullRequest(ref.Path)
 		return fmt.Sprintf("%s%s/pull-requests/%d", l.base, repo, d), nil
-	case scm.IsBranch(ref.Path) && ref.Sha == "":
+	case ref.Sha == "":
 		t := scm.TrimRef(ref.Path)
 
 		// Bitbucket has a bug where the "source view" link for
 		// a branch which contains a slash results in a 404.
 		// The link to the "branch view" works with names containing
 		// a slash so we do this for branches with slashes in its names.
 		// See https://jira.atlassian.com/browse/BCLOUD-14422 for more information
-		//
-		if strings.Contains(t, "/") {
+		if scm.IsBranch(ref.Path) && strings.Contains(t, "/") {
 			return fmt.Sprintf("%s%s/branch/%s", l.base, repo, t), nil
 		}