Skip to content

Report error from storeAccessToken() upstream. #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jaquish merged 1 commit into from
Sep 3, 2025
Merged

Report error from storeAccessToken() upstream. #444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Source/SwiftyDropbox/Shared/Handwritten/OAuth/OAuth.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,9 @@ public enum OAuth2Error: String, Error {

/// The state param received from the authorization server does not match the state param stored by the SDK.
case inconsistentState = "inconsistent_state"

/// Failed to save the token.
case tokenStorageError = "token_storage_error"

/// Some other error (outside of the OAuth2 specification)
case unknown
Expand Down
11 changes: 9 additions & 2 deletions Source/SwiftyDropbox/Shared/Handwritten/OAuth/OAuthImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,11 @@ public class DropboxOAuthManager: AccessTokenRefreshing {
}
if canHandleURL(url) {
extractFromUrl(url) { result in
var result = result
if case let .success(token) = result {
self.storeAccessToken(token)
if !self.storeAccessToken(token) {
result = .error(.tokenStorageError, nil)
}
}
completion(result)
}
Expand Down Expand Up @@ -425,8 +428,12 @@ public class DropboxOAuthManager: AccessTokenRefreshing {
uid: uid, refreshToken: refreshToken, scopes: scopes, appKey: appKey, locale: localeIdentifier
)
refreshRequest.start(queue: DispatchQueue.main) { [weak self] result in
var result = result
if case let .success(token) = result {
self?.storeAccessToken(token)
guard let self else { return }
if !self.storeAccessToken(token) {
result = .error(.tokenStorageError, nil)
}
}
(queue ?? DispatchQueue.main).async { completion(result) }
}
Expand Down