Closed
Conversation
- Remove non-existent run_node and shutdown_event from __init__.py exports - Update test_node.py to test available functions instead of missing ones - Fix code formatting with black - Partially fix linting issues with ruff The main CI issue was that tests were importing functions that didn't exist. This fixes the test collection failures and allows tests to run properly. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_nodeandshutdown_eventfunction exports that were causing test collection failuresRoot Cause
The CI was failing because:
src/node/__init__.pywas exporting functions that didn't exist (run_node,shutdown_event)tests/test_node.pywas trying to import these non-existent functionsChanges Made
__all__insrc/node/__init__.pytests/test_node.pyto test the actualmainfunction that existsTest Plan
🤖 Generated with Claude Code