Added optional extra_headers parameter#173
Open
wjdecorte wants to merge 2 commits intodruid-io:masterfrom
Open
Added optional extra_headers parameter#173wjdecorte wants to merge 2 commits intodruid-io:masterfrom
wjdecorte wants to merge 2 commits intodruid-io:masterfrom
Conversation
wjdecorte
force-pushed
the
f_add_extra_headers
branch
from
83c90c3 to
e9974db
Compare
Contributor
Author
|
Flake8 fails on the pre-commit hook due to lines being too long in test_client.py. Altering the problem lines in the test causes it to fail. I had to uninstall the pre-commit hooks in order to commit the code successfully. Either the Flake8 hook needs to be updated to ignore long lines or the tests need to be updated to not have long lines. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allowing for extra headers to be included in the request to Druid opens the ability to send "Accept-Encoding: gzip" and get the data returned from Druid in compressed format. The code was also updated to decompress the data if the response header included "Content-Encoding: gzip".