Exclude 202 status from failure handling to support MSQ queries#325
Open
vrrs wants to merge 1 commit intodruid-io:masterfrom
Open
Exclude 202 status from failure handling to support MSQ queries#325vrrs wants to merge 1 commit intodruid-io:masterfrom
vrrs wants to merge 1 commit intodruid-io:masterfrom
Conversation
Author
|
@gianm would really appreciate the review or tagging someone who might. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When submitting queries with pydruid to the new Druid MSQ engine, the client fails because it assumes that 202(non 200) status code indicates a failure. The MSQ engine whose endpoint is
druid/v2/sql/taskis an async API and returns the status of the query. Example{'taskId': 'query-cd91f1a2-0d15-4e2b-a858-3e2a7cc93374', 'state': 'RUNNING'}. With this small change, pydruid works as expected and returns one row.Related to this issue
Error
Test
I ran the following snippet