Support pluralization in I18n messages backend#465
Open
cutalion wants to merge 1 commit intodry-rb:mainfrom
Open
Support pluralization in I18n messages backend#465cutalion wants to merge 1 commit intodry-rb:mainfrom
cutalion wants to merge 1 commit intodry-rb:mainfrom
Conversation
Pass all provided options down to I18n.t method. It will use `:count`
option to pluralize the message.
en:
foo:
one: %{count} foo
other: %{count} foos
I18n.t(:foo, count: 1) #=> 1 foo
I18n.t(:foo, count: 1) #=> 2 foos
1f8a52f to
20f396c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turned out that pluralization in i81n backend does not work, because
:countis stripped out from provided options.I suggest to pass all options down to
I18n.tmethod. Already tested this in production with dry-validation.Not sure that the
metain case of pluralization should be returned when no:countprovided, becausemetaandtemplateare the same in that case. Is it ok?