update readme, add parse config error test

Author: dsa0x

.github/workflows/ci.yml

@@ -11,7 +11,7 @@ jobs:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
-        os: [ubuntu-latest, macos-latest, windows-latest]
+        os: [ubuntu-latest, macos-latest]
         go-version: ["1.17"]
     steps:
       - uses: actions/checkout@v2

Readme.md

@@ -147,11 +147,16 @@ type Config struct {
 
 If object is a map, the keys are the environment variables and the values are the values.
 
+### Note
+
+- Not tested with Windows.
+
 ### Todo or not todo
 
 - Add a `-force` flag to `sicher init` to overwrite the encrypted file if it already exists
 - Enable support for nested yaml env files
 - Add support for other types of encryption
+- Test on windows
 
 ### License
 

helpers.go

@@ -78,12 +78,11 @@ func generateKey() string {
 // parseConfig parses the environment variables into a map
 func parseConfig(config []byte, store map[string]string, envType EnvStyle) (err error) {
 
-	if envType != DOTENV && envType != YAML && envType != YML {
+	delim, ok := envStyleDelim[envType]
+	if !ok {
 		return errors.New("invalid environment type")
 	}
 
-	delim := envStyleDelim[envType]
-
 	var b bytes.Buffer
 	b.Write(config)
 	sc := bufio.NewScanner(&b)

helpers_test.go

@@ -161,29 +161,16 @@ func TestParseConfig(t *testing.T) {
 
 }
 
-func TestYamlParseConfig(t *testing.T) {
+func TestYamlParseConfigError(t *testing.T) {
 	enMap := make(map[string]string)
 	cfg := []byte(`
 PORT:8080
 URI:localhost
 #OLD_PORT:5000
 	`)
-	err := parseConfig(cfg, enMap, "yaml")
-	if err != nil {
-		t.Errorf("Unable to parse config; %v", err)
-	}
-
-	port, ok := enMap["PORT"]
-	if !ok {
-		t.Errorf("Expected config to have been marshalled into map")
-	}
-
-	if port != "8080" {
-		t.Errorf("Expected value to be %s, got %s", "8080", port)
-	}
-
-	if enMap["OLD_PORT"] != "" {
-		t.Errorf("Expected ignored value to not be parsed")
+	err := parseConfig(cfg, enMap, "wrong")
+	if err == nil {
+		t.Errorf("Expected error to be thrown when parsing wrong envType")
 	}
 }