Skip to content

VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jberezanski wants to merge 1 commit into
base: main
Choose a base branch
from
Open

VMNetworkAdapter: Fix Get- failing for a ManagementOS adapter #188

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ For older change log history see the [historic changelog](HISTORIC_CHANGELOG.md)
- Fixed VMName property in example.
- xVMNetworkAdapter
- Fixed MacAddress sample data.
- Fixed Get-TargetResource failing for a ManagementOS adapter while trying
to obtain guest IP settings.
- xVMSwitch
- Correctly return the state as `$true` or `$false` depending on the
`Ensure` property when the switch does not exist.
12 changes: 6 additions & 6 deletions source/DSCResources/MSFT_xVMNetworkAdapter/MSFT_xVMNetworkAdapter.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,13 +83,13 @@ function Get-TargetResource
{
$configuration.Add('MacAddress', $netAdapter.MacAddress)
$configuration.Add('DynamicMacAddress', $netAdapter.DynamicMacAddressEnabled)
}

$networkInfo = Get-NetworkInformation -VMName $VMName -Name $Name
if ($networkInfo)
{
$item = New-CimInstance -ClassName MSFT_xNetworkSettings -Property $networkInfo -Namespace root/microsoft/windows/desiredstateconfiguration -ClientOnly
$configuration.Add('NetworkSetting', $item)
$networkInfo = Get-NetworkInformation -VMName $VMName -Name $Name
if ($networkInfo)
{
$item = New-CimInstance -ClassName MSFT_xNetworkSettings -Property $networkInfo -Namespace root/microsoft/windows/desiredstateconfiguration -ClientOnly
$configuration.Add('NetworkSetting', $item)
}
}

$configuration.Add('Ensure', 'Present')
Expand Down