Skip to content

Test-SqlDscRSInstalled: Add command#2079

Merged
johlju merged 2 commits intodsccommunity:mainfrom
johlju:fix/issue#2078
Mar 13, 2025
Merged

Test-SqlDscRSInstalled: Add command#2079
johlju merged 2 commits intodsccommunity:mainfrom
johlju:fix/issue#2078

Conversation

@johlju
Copy link
Member

@johlju johlju commented Mar 12, 2025

Pull Request (PR) description

  • Test-SqlDscRSInstalled to test whether an instance is installed or not
    (issue #2078).

This Pull Request (PR) fixes the following issues

Task list

  • Added an entry to the change log under the Unreleased section of the
    file CHANGELOG.md. Entry should say what was changed and how that
    affects users (if applicable), and reference the issue being resolved
    (if applicable).
  • Resource documentation updated in the resource's README.md.
  • Resource parameter descriptions updated in schema.mof.
  • Comment-based help updated, including parameter descriptions.
  • Localization strings updated.
  • Examples updated.
  • Unit tests updated. See DSC Community Testing Guidelines.
  • Integration tests updated (where possible). See DSC Community Testing Guidelines.
  • Code changes adheres to DSC Community Style Guidelines.

This change is Reviewable

@johlju johlju requested a review from a team as a code owner March 12, 2025 17:58
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94%. Comparing base (a8befef) to head (9f2617b).
Report is 16 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #2079   +/-   ##
====================================
  Coverage    94%     94%           
====================================
  Files       103     104    +1     
  Lines      8083    8090    +7     
====================================
+ Hits       7656    7663    +7     
  Misses      427     427           
Flag Coverage Δ
unit ∅ <100%> (∅)
Files with missing lines Coverage Δ
source/Public/Test-SqlDscRSInstalled.ps1 100% <100%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@johlju johlju added the needs review The pull request needs a code review. label Mar 12, 2025
Copy link
Member Author

@johlju johlju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @johlju)

@johlju johlju merged commit a3d9ab3 into dsccommunity:main Mar 13, 2025
52 checks passed
@johlju johlju deleted the fix/issue#2078 branch March 13, 2025 09:11
@johlju johlju removed the needs review The pull request needs a code review. label Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test-SqlDscRSIsInstalled: New command proposal

1 participant

Comments