Add new commands to enable and disable SQL Server logins with comprehensive testing#2138

Merged

johlju merged 27 commits intomainfrom

copilot/fix-d72cecdf-f0f0-4228-989b-b7d653c160ee

Aug 23, 2025

Commits on Aug 22, 2025

Merge main branch with conflict resolution
Copilot
committed
Rebase PR onto latest main and enhance New-SqlDscLogin integration tests

Copilot
and
johlju
committed
Fix bad instruction
johlju
authored
Use persistent logins for integration tests and remove cleanup code

Copilot
and
johlju
committed
Remove duplicate Enable() and Disable() methods from Login class in SMO.cs

Copilot
and
johlju
committed
Replace SMO method calls with new commands in integration tests and revert New-SqlDscLogin file

Copilot
and
johlju
committed
Simplify BeforeEach blocks and add ErrorAction Stop to login commands

Copilot
and
johlju
committed

Commits on Aug 23, 2025

Add parameter attribute validation tests, fix InModuleScope usage, add WhatIf tests, and improve error testing

Copilot
and
johlju
committed
Apply suggestion from @coderabbitai[bot]

johlju
and
coderabbitai[bot]
authored
Apply suggestion from @coderabbitai[bot]

johlju
and
coderabbitai[bot]
authored
Apply suggestion from @coderabbitai[bot]

johlju
and
coderabbitai[bot]
authored
Apply suggestion from @coderabbitai[bot]

johlju
and
coderabbitai[bot]
authored
Fix command OutputType and integration test improvements

Copilot
and
johlju
committed
Update CHANGELOG.md

johlju
and
coderabbitai[bot]
authored
Update source/Public/Disable-SqlDscLogin.ps1

johlju
and
coderabbitai[bot]
authored
Replace OutputType with empty attribute for void commands

Copilot
and
johlju
committed
Address code review feedback: improve variable naming, documentation, and test coverage

Copilot
and
johlju
committed
Address code review feedback: remove ValueFromPipelineByPropertyName, use Should -Invoke assertions, and remove redundant tests

Copilot
and
johlju
committed
Update CHANGELOG.md

johlju
and
coderabbitai[bot]
authored
Update source/Public/Test-SqlDscIsLoginEnabled.ps1

johlju
and
coderabbitai[bot]
authored
Update source/Public/Disable-SqlDscLogin.ps1

johlju
and
coderabbitai[bot]
authored
Update tests/Integration/Commands/Test-SqlDscIsLoginEnabled.Integration.Tests.ps1

johlju
and
coderabbitai[bot]
authored
Fix Get-SqlDscLogin mock to return single object instead of array in Test-SqlDscIsLoginEnabled unit tests

Copilot
and
johlju
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add new commands to enable and disable SQL Server logins with comprehensive testing#2138

Add new commands to enable and disable SQL Server logins with comprehensive testing#2138
johlju merged 27 commits intomainfrom
copilot/fix-d72cecdf-f0f0-4228-989b-b7d653c160ee

Commits on Aug 17, 2025

Initial plan

Add SQL Server login enable/disable commands with comprehensive tests

Fix newlines and add comprehensive integration tests for login commands

Fix newlines and remove trailing whitespace from all files per coding guidelines

Commits on Aug 22, 2025

Merge main branch with conflict resolution

Rebase PR onto latest main and enhance New-SqlDscLogin integration tests

Fix bad instruction

Use persistent logins for integration tests and remove cleanup code

Remove duplicate Enable() and Disable() methods from Login class in SMO.cs

Replace SMO method calls with new commands in integration tests and revert New-SqlDscLogin file

Simplify BeforeEach blocks and add ErrorAction Stop to login commands

Commits on Aug 23, 2025

Add parameter attribute validation tests, fix InModuleScope usage, add WhatIf tests, and improve error testing

Apply suggestion from @coderabbitai[bot]

Apply suggestion from @coderabbitai[bot]

Apply suggestion from @coderabbitai[bot]

Apply suggestion from @coderabbitai[bot]

Fix command OutputType and integration test improvements

Update CHANGELOG.md

Update source/Public/Disable-SqlDscLogin.ps1

Replace OutputType with empty attribute for void commands

Address code review feedback: improve variable naming, documentation, and test coverage

Address code review feedback: remove ValueFromPipelineByPropertyName, use Should -Invoke assertions, and remove redundant tests

Update CHANGELOG.md

Update source/Public/Test-SqlDscIsLoginEnabled.ps1

Update source/Public/Disable-SqlDscLogin.ps1

Update tests/Integration/Commands/Test-SqlDscIsLoginEnabled.Integration.Tests.ps1

Fix Get-SqlDscLogin mock to return single object instead of array in Test-SqlDscIsLoginEnabled unit tests