Skip to content

Fix powershell instructions #2147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johlju merged 1 commit into from
Aug 22, 2025
+3 −2
Merged

Fix powershell instructions #2147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/instructions/dsc-community-style-guidelines-powershell.instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ function Get-Something
- Use `PSCredential` for credentials
- Avoid hardcoded computer names, use cross-platform [`Get-ComputerName`](https://github.com/dsccommunity/DscResource.Common/wiki/Get%E2%80%91ComputerName) instead of `$env:COMPUTERNAME`
- Place `$null` on left side of comparisons
- Avoid empty catch blocks (use `-ErrorAction Ignore`)
- Avoid empty catch blocks (instead use `-ErrorAction SilentlyContinue`)
- Don't use `Invoke-Expression` (use `&` operator)
- Use CIM commands instead of WMI commands

Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Improved documentation with optimized analysis workflow description.
- DSC community style guidelines
- Added requirement to follow guidelines over existing code patterns.
- Improved markdown and changelog instructions.
- Improved markdown, pester, powershell, and changelog instructions.
- Fixed `Ingore` that seems in edge-cases fail.

## [17.1.0] - 2025-05-22

Expand Down
Loading