-
Notifications
You must be signed in to change notification settings - Fork 227
Add integration test for Get-SqlDscManagedComputer command #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
tests/Integration/Commands/Get-SqlDscManagedComputer.Integration.Tests.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| [System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Suppressing this rule because Script Analyzer does not understand Pester syntax.')] | ||
| param () | ||
|
|
||
| BeforeDiscovery { | ||
| try | ||
| { | ||
| if (-not (Get-Module -Name 'DscResource.Test')) | ||
| { | ||
| # Assumes dependencies have been resolved, so if this module is not available, run 'noop' task. | ||
| if (-not (Get-Module -Name 'DscResource.Test' -ListAvailable)) | ||
| { | ||
| # Redirect all streams to $null, except the error stream (stream 2) | ||
| & "$PSScriptRoot/../../../build.ps1" -Tasks 'noop' 3>&1 4>&1 5>&1 6>&1 > $null | ||
| } | ||
|
|
||
| # If the dependencies have not been resolved, this will throw an error. | ||
| Import-Module -Name 'DscResource.Test' -Force -ErrorAction 'Stop' | ||
| } | ||
| } | ||
| catch [System.IO.FileNotFoundException] | ||
| { | ||
| throw 'DscResource.Test module dependency not found. Please run ".\build.ps1 -ResolveDependency -Tasks noop" first.' | ||
| } | ||
| } | ||
|
|
||
| BeforeAll { | ||
| $script:moduleName = 'SqlServerDsc' | ||
|
|
||
| Import-Module -Name $script:moduleName -Force -ErrorAction 'Stop' | ||
| } | ||
|
|
||
| # cSpell: ignore DSCSQLTEST | ||
| Describe 'Get-SqlDscManagedComputer' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') { | ||
| BeforeAll { | ||
| Write-Verbose -Message ('Running integration test as user ''{0}''.' -f $env:UserName) -Verbose | ||
|
|
||
| # Starting the named instance SQL Server service prior to running tests. | ||
| # Note: On Windows CI environment, this would start the SQL Server service | ||
| if (Get-Command -Name 'Start-Service' -ErrorAction 'SilentlyContinue') | ||
| { | ||
| Start-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop' | ||
| } | ||
|
|
||
| $script:mockServerName = Get-ComputerName | ||
| } | ||
|
|
||
| AfterAll { | ||
| # Stop the named instance SQL Server service to save memory on the build worker. | ||
| # Note: On Windows CI environment, this would stop the SQL Server service | ||
| if (Get-Command -Name 'Stop-Service' -ErrorAction 'SilentlyContinue') | ||
| { | ||
| Stop-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop' | ||
| } | ||
| } | ||
|
|
||
| Context 'When using default parameters' { | ||
| It 'Should return the managed computer object for the local computer' { | ||
| $result = Get-SqlDscManagedComputer -ErrorAction 'Stop' | ||
|
|
||
| $result | Should -Not -BeNullOrEmpty | ||
| $result | Should -BeOfType ([Microsoft.SqlServer.Management.Smo.Wmi.ManagedComputer]) | ||
| $result.Name | Should -Be $script:mockServerName | ||
| } | ||
| } | ||
|
|
||
| Context 'When specifying a server name' { | ||
| It 'Should return the managed computer object for the specified server' { | ||
| $result = Get-SqlDscManagedComputer -ServerName $script:mockServerName -ErrorAction 'Stop' | ||
|
|
||
| $result | Should -Not -BeNullOrEmpty | ||
| $result | Should -BeOfType ([Microsoft.SqlServer.Management.Smo.Wmi.ManagedComputer]) | ||
| $result.Name | Should -Be $script:mockServerName | ||
| } | ||
| } | ||
|
|
||
| Context 'When validating SMO object properties' { | ||
| It 'Should return objects with correct SMO properties' { | ||
| $result = Get-SqlDscManagedComputer -ServerName $script:mockServerName -ErrorAction 'Stop' | ||
|
|
||
| # Verify it's a proper SMO ManagedComputer object | ||
| $result | Should -BeOfType ([Microsoft.SqlServer.Management.Smo.Wmi.ManagedComputer]) | ||
|
|
||
| # Verify key properties exist | ||
| $result.Name | Should -Not -BeNullOrEmpty | ||
| $result.Name | Should -Be $script:mockServerName | ||
|
|
||
| # Verify ServerInstances collection is accessible | ||
| $result.ServerInstances | Should -Not -BeNullOrEmpty | ||
| $result.ServerInstances.Count | Should -BeGreaterThan 0 | ||
|
|
||
| # Verify Services collection is accessible | ||
| $result.Services | Should -Not -BeNullOrEmpty | ||
| $result.Services.Count | Should -BeGreaterThan 0 | ||
|
|
||
| # Verify the DSCSQLTEST instance is present in the ServerInstances collection | ||
| $testInstance = $result.ServerInstances | Where-Object -FilterScript { $_.Name -eq 'DSCSQLTEST' } | ||
| $testInstance | Should -Not -BeNullOrEmpty | ||
| $testInstance.Name | Should -Be 'DSCSQLTEST' | ||
| } | ||
| } | ||
|
|
||
| Context 'When using the managed computer object with other commands' { | ||
| It 'Should be compatible with Get-SqlDscManagedComputerInstance' { | ||
| $managedComputer = Get-SqlDscManagedComputer -ServerName $script:mockServerName -ErrorAction 'Stop' | ||
|
|
||
| # Test pipeline compatibility | ||
| $result = $managedComputer | Get-SqlDscManagedComputerInstance -InstanceName 'DSCSQLTEST' -ErrorAction 'Stop' | ||
|
|
||
| $result | Should -Not -BeNullOrEmpty | ||
| $result | Should -BeOfType ([Microsoft.SqlServer.Management.Smo.Wmi.ServerInstance]) | ||
| $result.Name | Should -Be 'DSCSQLTEST' | ||
| $result.Parent.Name | Should -Be $script:mockServerName | ||
| } | ||
| } | ||
|
|
||
| Context 'When testing error handling' { | ||
| It 'Should handle non-existent server names gracefully' { | ||
| # This test verifies that the command creates a ManagedComputer object | ||
| # even for non-existent servers (SMO behavior) | ||
| $result = Get-SqlDscManagedComputer -ServerName 'NonExistentServer123' -ErrorAction 'Stop' | ||
|
|
||
| $result | Should -Not -BeNullOrEmpty | ||
| $result | Should -BeOfType ([Microsoft.SqlServer.Management.Smo.Wmi.ManagedComputer]) | ||
| $result.Name | Should -Be 'NonExistentServer123' | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.