-
Notifications
You must be signed in to change notification settings - Fork 227
Add integration tests for Get-SqlDscAudit command #2254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c0cb0f5
Initial plan
Copilot 3ea5ef9
Add integration tests for Get-SqlDscAudit command
Copilot 16ca44e
Fix integration test issues: correct Pester syntax, task reference, f…
Copilot 42e6d66
Merge branch 'main' into copilot/fix-2222
johlju 45965be
Merge branch 'main' into copilot/fix-2222
johlju File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
165 changes: 165 additions & 0 deletions
165
tests/Integration/Commands/Get-SqlDscAudit.Integration.Tests.ps1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,165 @@ | ||
| [System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSUseDeclaredVarsMoreThanAssignments', '', Justification = 'Suppressing this rule because Script Analyzer does not understand Pester syntax.')] | ||
| param () | ||
|
|
||
| BeforeDiscovery { | ||
| try | ||
| { | ||
| if (-not (Get-Module -Name 'DscResource.Test')) | ||
| { | ||
| # Assumes dependencies have been resolved, so if this module is not available, run 'noop' task. | ||
| if (-not (Get-Module -Name 'DscResource.Test' -ListAvailable)) | ||
| { | ||
| # Redirect all streams to $null, except the error stream (stream 2) | ||
| & "$PSScriptRoot/../../../build.ps1" -Tasks 'noop' 3>&1 4>&1 5>&1 6>&1 > $null | ||
| } | ||
|
|
||
| # If the dependencies have not been resolved, this will throw an error. | ||
| Import-Module -Name 'DscResource.Test' -Force -ErrorAction 'Stop' | ||
| } | ||
| } | ||
| catch [System.IO.FileNotFoundException] | ||
| { | ||
| throw 'DscResource.Test module dependency not found. Please run ".\build.ps1 -ResolveDependency -Tasks noop" first.' | ||
| } | ||
| } | ||
|
|
||
| BeforeAll { | ||
| $script:moduleName = 'SqlServerDsc' | ||
|
|
||
| Import-Module -Name $script:moduleName -Force -ErrorAction 'Stop' | ||
| } | ||
|
|
||
| Describe 'Get-SqlDscAudit' -Tag @('Integration_SQL2017', 'Integration_SQL2019', 'Integration_SQL2022') { | ||
| BeforeAll { | ||
| # Starting the named instance SQL Server service prior to running tests. | ||
| Start-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop' | ||
|
|
||
| $script:mockInstanceName = 'DSCSQLTEST' | ||
| $script:mockComputerName = Get-ComputerName | ||
|
|
||
| $mockSqlAdministratorUserName = 'SqlAdmin' # Using computer name as NetBIOS name throw exception. | ||
| $mockSqlAdministratorPassword = ConvertTo-SecureString -String 'P@ssw0rd1' -AsPlainText -Force | ||
|
|
||
| $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword) | ||
|
|
||
| $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction Stop | ||
|
|
||
| # Create test audits for the tests | ||
| $script:testAuditName1 = 'SqlDscTestGetAudit1_' + (Get-Random) | ||
| $script:testAuditName2 = 'SqlDscTestGetAudit2_' + (Get-Random) | ||
|
|
||
| $null = New-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName1 -LogType 'ApplicationLog' -Force -ErrorAction Stop | ||
| $null = New-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName2 -LogType 'ApplicationLog' -Force -ErrorAction Stop | ||
| } | ||
|
|
||
| AfterAll { | ||
| # Clean up test audits | ||
| $testAuditsToRemove = @($script:testAuditName1, $script:testAuditName2) | ||
|
|
||
| foreach ($auditName in $testAuditsToRemove) | ||
| { | ||
| try | ||
| { | ||
| $existingAudit = Get-SqlDscAudit -ServerObject $script:serverObject -Name $auditName -ErrorAction 'SilentlyContinue' | ||
| if ($existingAudit) | ||
| { | ||
| $null = Remove-SqlDscAudit -ServerObject $script:serverObject -Name $auditName -Force -ErrorAction 'SilentlyContinue' | ||
| } | ||
| } | ||
| catch | ||
| { | ||
| # Ignore cleanup errors | ||
| } | ||
| } | ||
|
|
||
| Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject | ||
|
|
||
| # Stop the named instance SQL Server service to save memory on the build worker. | ||
| Stop-Service -Name 'MSSQL$DSCSQLTEST' -Verbose -ErrorAction 'Stop' | ||
| } | ||
|
|
||
| Context 'When getting all SQL Server audits' { | ||
| It 'Should return an array of Audit objects' { | ||
| $result = Get-SqlDscAudit -ServerObject $script:serverObject | ||
|
|
||
| <# | ||
| Casting to array to ensure we get the count on Windows PowerShell | ||
| when there is only one audit. | ||
| #> | ||
| @($result).Count | Should -BeGreaterOrEqual 2 | ||
| @($result)[0] | Should -BeOfType 'Microsoft.SqlServer.Management.Smo.Audit' | ||
| } | ||
|
|
||
| It 'Should return test audits that were created' { | ||
| $result = Get-SqlDscAudit -ServerObject $script:serverObject | ||
|
|
||
| $result.Name | Should -Contain $script:testAuditName1 | ||
| $result.Name | Should -Contain $script:testAuditName2 | ||
| } | ||
| } | ||
|
|
||
| Context 'When getting a specific SQL Server audit' { | ||
| It 'Should return the specified audit when it exists' { | ||
| $result = Get-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName1 | ||
|
|
||
| $result | Should -BeOfType 'Microsoft.SqlServer.Management.Smo.Audit' | ||
| $result.Name | Should -Be $script:testAuditName1 | ||
| } | ||
|
|
||
| It 'Should throw an error when the audit does not exist' { | ||
| { Get-SqlDscAudit -ServerObject $script:serverObject -Name 'NonExistentAudit' -ErrorAction 'Stop' } | | ||
| Should -Throw | ||
| } | ||
|
|
||
| It 'Should return null when the audit does not exist and error action is SilentlyContinue' { | ||
| $result = Get-SqlDscAudit -ServerObject $script:serverObject -Name 'NonExistentAudit' -ErrorAction 'SilentlyContinue' | ||
|
|
||
| $result | Should -BeNullOrEmpty | ||
| } | ||
| } | ||
|
|
||
| Context 'When using the Refresh parameter' { | ||
| It 'Should return the same results with and without Refresh for all audits' { | ||
| $resultWithoutRefresh = Get-SqlDscAudit -ServerObject $script:serverObject | ||
| $resultWithRefresh = Get-SqlDscAudit -ServerObject $script:serverObject -Refresh | ||
|
|
||
| @($resultWithoutRefresh).Count | Should -Be @($resultWithRefresh).Count | ||
| } | ||
|
|
||
| It 'Should return the same result with and without Refresh for specific audit' { | ||
| $resultWithoutRefresh = Get-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName1 | ||
| $resultWithRefresh = Get-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName1 -Refresh | ||
|
|
||
| $resultWithoutRefresh.Name | Should -Be $resultWithRefresh.Name | ||
| $resultWithoutRefresh.Name | Should -Be $script:testAuditName1 | ||
| } | ||
| } | ||
|
|
||
| Context 'When using pipeline input' { | ||
| It 'Should accept ServerObject from pipeline for all audits' { | ||
| $result = $script:serverObject | Get-SqlDscAudit | ||
|
|
||
| @($result).Count | Should -BeGreaterOrEqual 2 | ||
| $result.Name | Should -Contain $script:testAuditName1 | ||
| $result.Name | Should -Contain $script:testAuditName2 | ||
| } | ||
|
|
||
| It 'Should accept ServerObject from pipeline for specific audit' { | ||
| $result = $script:serverObject | Get-SqlDscAudit -Name $script:testAuditName1 | ||
|
|
||
| $result | Should -BeOfType 'Microsoft.SqlServer.Management.Smo.Audit' | ||
| $result.Name | Should -Be $script:testAuditName1 | ||
| } | ||
| } | ||
|
|
||
| Context 'When testing audit properties' { | ||
| It 'Should return audits with expected properties' { | ||
| $result = Get-SqlDscAudit -ServerObject $script:serverObject -Name $script:testAuditName1 | ||
|
|
||
| $result.Name | Should -Be $script:testAuditName1 | ||
| $result.Parent | Should -Be $script:serverObject | ||
| $result.Enabled | Should -Not -BeNull | ||
| $result.DestinationType | Should -Not -BeNull | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.