-
Notifications
You must be signed in to change notification settings - Fork 227
Add integration test for ConvertFrom-SqlDscServerPermission command #2272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: johlju <[email protected]>
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Comment |
tests/Integration/Commands/ConvertFrom-SqlDscServerPermission.Integration.Tests.ps1
Outdated
Show resolved
Hide resolved
tests/Integration/Commands/ConvertFrom-SqlDscServerPermission.Integration.Tests.ps1
Outdated
Show resolved
Hide resolved
tests/Integration/Commands/ConvertFrom-SqlDscServerPermission.Integration.Tests.ps1
Show resolved
Hide resolved
Co-authored-by: johlju <[email protected]>
Adding integration test for ConvertFrom-SqlDscServerPermission command.
Plan
The integration test successfully validates that ConvertFrom-SqlDscServerPermission correctly converts ServerPermission objects into SMO ServerPermissionSet objects. The test covers:
All tests pass and ensure the command works properly in real-world scenarios.
Fixes #2210.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is