Skip to content

Remove Should -Not -Throw #2302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johlju merged 26 commits into from
Oct 12, 2025

Remove unnecessary closing brace in Invoke-SqlDscQuery integration test

81bbdbf
Select commit
Loading
Failed to load commit list.
Merged

Remove Should -Not -Throw #2302

Remove unnecessary closing brace in Invoke-SqlDscQuery integration test
81bbdbf
Select commit
Loading
Failed to load commit list.
Azure Pipelines / dsccommunity.SqlServerDsc succeeded Oct 12, 2025 in 1h 30m 40s

Build #17.3.0-PR2302.27 had test failures

0 errors / 2 warnings

Details

Tests

  • Failed: 2 (0.01%)
  • Passed: 27,148 (99.40%)
  • Other: 162 (0.59%)
  • Total: 27,312
Code coverage

  • 149 of 149 class covered (100.00%)
  • 9716 of 10321 instruction covered (94.14%)
  • 8751 of 9239 line covered (94.72%)
  • 372 of 392 method covered (94.90%)

Annotations

Check failure on line 1 in Get-SqlDscStartupParameter.When validating output properties.Should return an object with expected LogFilePath property

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Get-SqlDscStartupParameter.When validating output properties.Should return an object with expected LogFilePath property 

Expected regular expression '\.ldf$' to match 'C:\Program Files\Microsoft SQL Server\MSSQL16.DSCSQLTEST\MSSQL\DATA\mastlog.ldf呌卅屔卍兓L', but it did not match.
Raw output 
at $script:result.LogFilePath | Should -Match '\.ldf$', D:\a\1\s\tests\Integration\Commands\Get-SqlDscStartupParameter.Integration.Tests.ps1:144
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11334
at <ScriptBlock>, D:\a\1\s\tests\Integration\Commands\Get-SqlDscStartupParameter.Integration.Tests.ps1:144
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.3\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:703
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:675
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:675
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:854
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\c9af6507-5b3e-45ed-b4b9-15817b76bd5e.ps1:84
at <ScriptBlock>, <No file>:1

Check failure on line 1 in Get-SqlDscStartupParameter.When comparing results from different parameter sets.Should return the same results for ByServerName and ByServiceObject parameter sets

See this annotation in the file changed.

@azure-pipelines azure-pipelines / dsccommunity.SqlServerDsc

Get-SqlDscStartupParameter.When comparing results from different parameter sets.Should return the same results for ByServerName and ByServiceObject parameter sets 

Expected strings to be the same, but they were different.
Expected length: 79
Actual length:   85
Strings differ at index 79.
Expected: 'C:\Program Files\Microsoft SQL Server\MSSQL16.DSCSQLTEST\MSSQL\DATA\mastlog.ldf'
But was:  'C:\Program Files\Microsoft SQL Server\MSSQL16.DSCSQLTEST\MSSQL\DATA\mastlog.ldf䵜卓䱑䱜䝏\'
           -------------------------------------------------------------------------------^
Raw output 
at $resultByServerName.LogFilePath | Should -Be $resultByServiceObject.LogFilePath, D:\a\1\s\tests\Integration\Commands\Get-SqlDscStartupParameter.Integration.Tests.ps1:182
at Invoke-Assertion, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11391
at Should<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:11330
at <ScriptBlock>, D:\a\1\s\tests\Integration\Commands\Get-SqlDscStartupParameter.Integration.Tests.ps1:182
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2206
at Invoke-TestItem, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1254
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:890
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:948
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2073
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2034
at Invoke-ScriptBlock, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2209
at Invoke-Block, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:995
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1737
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.ps1:3
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3150
at Invoke-InNewScriptScope, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:3157
at Run-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:1740
at Invoke-Test, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:2554
at Invoke-Pester<End>, D:\a\1\s\output\RequiredModules\Pester\6.0.0\Pester.psm1:5050
at <ScriptBlock>, D:\a\1\s\output\RequiredModules\Sampler\0.118.3\tasks\Invoke-Pester.pester.build.ps1:906
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:703
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:675
at *Task, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:675
at <ScriptBlock><End>, D:\a\1\s\output\RequiredModules\InvokeBuild\5.14.20\Invoke-Build.ps1:854
at <ScriptBlock><Begin>, D:\a\1\s\build.ps1:532
at <ScriptBlock>, D:\a\_temp\c9af6507-5b3e-45ed-b4b9-15817b76bd5e.ps1:84
at <ScriptBlock>, <No file>:1
View more details on Azure Pipelines