Setup is responsible for determining hardlink support, not the depot.

Author: mitchell-as

pkg/runtime/depot.go

@@ -51,11 +51,10 @@ func (e ErrVolumeMismatch) Error() string {
 }
 
 type depot struct {
-	config            depotConfig
-	depotPath         string
-	artifacts         map[strfmt.UUID]struct{}
-	fsMutex           *sync.Mutex
-	SupportsHardLinks bool
+	config    depotConfig
+	depotPath string
+	artifacts map[strfmt.UUID]struct{}
+	fsMutex   *sync.Mutex
 }
 
 func newDepot(runtimePath string) (*depot, error) {
@@ -75,10 +74,9 @@ func newDepot(runtimePath string) (*depot, error) {
 		config: depotConfig{
 			Deployments: map[strfmt.UUID][]deployment{},
 		},
-		depotPath:         depotPath,
-		artifacts:         map[strfmt.UUID]struct{}{},
-		fsMutex:           &sync.Mutex{},
-		SupportsHardLinks: supportsHardLinks(depotPath),
+		depotPath: depotPath,
+		artifacts: map[strfmt.UUID]struct{}{},
+		fsMutex:   &sync.Mutex{},
 	}
 
 	if !fileutils.TargetExists(depotPath) {
@@ -148,10 +146,6 @@ func (d *depot) Put(id strfmt.UUID) error {
 
 // DeployViaLink will take an artifact from the depot and link it to the target path.
 func (d *depot) DeployViaLink(id strfmt.UUID, relativeSrc, absoluteDest string) error {
-	if !d.SupportsHardLinks {
-		return errs.New("depot does not support hard links; use copy instead")
-	}
-
 	d.fsMutex.Lock()
 	defer d.fsMutex.Unlock()
 

pkg/runtime/setup.go

@@ -470,7 +470,7 @@ func (s *setup) install(id strfmt.UUID) (rerr error) {
 		if err := envDef.ApplyFileTransforms(s.path); err != nil {
 			return errs.Wrap(err, "Could not apply env transforms")
 		}
-	} else if s.depot.SupportsHardLinks {
+	} else if supportsHardLinks(s.depot.depotPath) {
 		if err := s.depot.DeployViaLink(id, envDef.InstallDir, s.path); err != nil {
 			return errs.Wrap(err, "Could not deploy artifact via link")
 		}