Fetching data for admin page using redux#125
Open
Subhang23 wants to merge 6 commits intodsciitpatna:masterfrom
Subhang23:master
Open
Fetching data for admin page using redux#125Subhang23 wants to merge 6 commits intodsciitpatna:masterfrom Subhang23:master
Subhang23 wants to merge 6 commits intodsciitpatna:masterfrom
Subhang23:master
Conversation
harsh-jindal
suggested changes
May 28, 2019
src/redux/actions/adminActions.js
Outdated
|
|
||
| export const fetchCategory =()=>{ | ||
| return dispatch =>{ | ||
| axios.get('https://jsonplaceholder.typicode.com/posts') |
Member
There was a problem hiding this comment.
@Subhang23 I dont understand from which url are you fetching/posting the categories too. I requested changes before that time you have resolved without making any change.
Member
|
@Subhang23 Attach the surge link. Please follow PR template strictly. |
harsh-jindal
suggested changes
May 29, 2019
src/redux/actions/adminActions.js
Outdated
| }; | ||
|
|
||
| export const deleteCategory =(e)=> (dispatch,getState) =>{ | ||
| const config = tokenConfig(getState); |
Member
There was a problem hiding this comment.
No need to create a new variable config. directly use tokenConfig(getState) in the axios call
Member
|
@Subhang23 Make the above changes. A lot of places the code can be improved but I guess that can be done later on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #112
Changes: Added fetch ,add and delete category