Open
Conversation
Member
|
@ritwizsinha @pranaykgupta Review the PR. |
pranaykgupta
suggested changes
Aug 14, 2019
Contributor
pranaykgupta
left a comment
pranaykgupta
left a comment
There was a problem hiding this comment.
@Subhang23 while updating the category name of existing user it is misbehaving, i.e, creating a new category instead of updating previous one.
Contributor
Author
|
@pranaykgupta i have fixed it |
Contributor
|
@Subhang23 while updating the category name, existing value should appear pre-filled in update form, also enclose whole table in a container. |
ritwizsinha
approved these changes
Aug 19, 2019
Contributor
ritwizsinha
left a comment
ritwizsinha
left a comment
There was a problem hiding this comment.
Make the change suggested @pranaykgupta , otherwise looks good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #176
Changes: Improved the ui
Surge Deployment Link: https://pr-176-sahaayak.surge.sh
Screenshots for the change:
