Skip to content

perf: replace recursion with iteration #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rubenporras merged 1 commit into from
Nov 28, 2024
Merged

perf: replace recursion with iteration #1029

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 34 additions & 10 deletions ...ols.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/ProxyCompositeNode.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,9 @@
package com.avaloq.tools.ddk.xtext.resource.persistence;

import java.io.IOException;
import java.util.ArrayDeque;
import java.util.ArrayList;
import java.util.Deque;
import java.util.List;

import org.eclipse.emf.common.notify.Adapter;
Expand All @@ -21,8 +23,9 @@
import org.eclipse.emf.common.util.TreeIterator;
import org.eclipse.emf.common.util.WrappedException;
import org.eclipse.emf.ecore.EObject;
import org.eclipse.emf.ecore.EStructuralFeature;
import org.eclipse.emf.ecore.impl.EClassImpl;
import org.eclipse.emf.ecore.resource.Resource;
import org.eclipse.emf.ecore.util.EContentsEList.FeatureIterator;
import org.eclipse.xtext.nodemodel.BidiIterable;
import org.eclipse.xtext.nodemodel.BidiTreeIterable;
import org.eclipse.xtext.nodemodel.BidiTreeIterator;
Expand Down Expand Up @@ -80,24 +83,45 @@ static void installProxyNodeModel(final Resource resource) {
ProxyCompositeNode rootNode = installProxyNodeModel(root, idToEObjectMap);
idToEObjectMap.trimToSize();
rootNode.idToEObjectMap = idToEObjectMap;

if (resource instanceof XtextResource) {
((XtextResource) resource).setParseResult(new ParseResult(root, rootNode, false));
}
}

@SuppressWarnings("unchecked")
private static ProxyCompositeNode installProxyNodeModel(final EObject eObject, final List<EObject> map) {
ProxyCompositeNode result = new ProxyCompositeNode();
eObject.eAdapters().add(result);
Deque<EObject> deque = new ArrayDeque<>();
ProxyCompositeNode rootComposite = new ProxyCompositeNode();
eObject.eAdapters().add(rootComposite);
map.add(eObject);

for (FeatureIterator<EObject> it = (FeatureIterator<EObject>) eObject.eContents().iterator(); it.hasNext();) {
EObject child = it.next();
if (!it.feature().isTransient()) {
installProxyNodeModel(child, map);
deque.push(eObject);

while (!deque.isEmpty()) {
EObject nextEObject = deque.pop();
EStructuralFeature[] structuralFeatures = ((EClassImpl.FeatureSubsetSupplier) nextEObject.eClass().getEAllStructuralFeatures()).containments();
if (structuralFeatures != null) {
for (int i = structuralFeatures.length - 1; i >= 0; i--) {
EStructuralFeature eStructuralFeature = structuralFeatures[i];
if (!eStructuralFeature.isTransient() && nextEObject.eIsSet(eStructuralFeature)) {
if (eStructuralFeature.isMany()) {
EList<EObject> listChild = (EList<EObject>) nextEObject.eGet(eStructuralFeature);
for (int j = listChild.size() - 1; j >= 0; j--) {
EObject singleChild = listChild.get(j);
singleChild.eAdapters().add(new ProxyCompositeNode());
map.add(singleChild);
deque.push(singleChild);
}
} else {
EObject singleChild = (EObject) nextEObject.eGet(eStructuralFeature);
singleChild.eAdapters().add(new ProxyCompositeNode());
map.add(singleChild);
deque.push(singleChild);
}
}
}
}
}
return result;
return rootComposite;
}

/**
Expand Down