chore: address PMD and Checkstyle markers #1235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joaodinissf
force-pushed
the
fix-pmd-checkstyle
branch
5 times, most recently
from
6dbc53e to
606c4cc
Compare
rubenporras
reviewed
Dec 4, 2025
....tools.ddk.check.core/src/com/avaloq/tools/ddk/check/jvmmodel/CheckJvmModelInferrerUtil.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/jupiter/BugTestAwareRule.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/jupiter/IssueAwareRule.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/jupiter/LoggingRule.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
....ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/IStandaloneBuilderParticipant.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...text.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractAcfContentAssistTest.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...ools.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/builder/XtextBuilderInjectorProvider.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...s.ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/jupiter/formatter/AbstractFormatterTest.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...ddk.xtext.test/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNameSegmentTreeLookupTest.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...k.xtext.test/src/com/avaloq/tools/ddk/xtext/resource/AbstractXtextTestsInjectorProvider.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...valoq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/DefaultXtextTargetPlatform.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...ext/src/com/avaloq/tools/ddk/xtext/resource/extensions/AbstractResourceDescriptionsData.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...t/src/com/avaloq/tools/ddk/xtext/resource/extensions/DelegatingResourceDescriptionsData.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
....ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/IResourceDescriptionsData.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...ools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...k.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/NonLockingBufferInputStream.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...valoq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/DerivedObjectAssociations.java
Show resolved
Hide resolved
rubenporras
reviewed
Dec 4, 2025
...ools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/IDerivedObjectAssociationsAccess.java
Show resolved
Hide resolved
rubenporras
requested changes
Dec 4, 2025
Member
rubenporras
left a comment
rubenporras
left a comment
There was a problem hiding this comment.
many changes due to WS characters in files which are otherwise left untouched. I did not comment on those,, as I did not check till the end.
Collaborator
Author
|
These WS changes will go away when I rebase on master. I'll move the PR out of draft state once it's ready for you to take a look. |
joaodinissf
force-pushed
the
fix-pmd-checkstyle
branch
from
606c4cc to
404ed5b
Compare
joaodinissf
force-pushed
the
fix-pmd-checkstyle
branch
from
404ed5b to
0fe6e8d
Compare
Member
|
This is a duplicate of the PR we have just merged, right? If so, close? |
Collaborator
Author
|
Yes, this could have been merged before separately. Can be closed now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.