Skip to content
This repository was archived by the owner on Jun 16, 2022. It is now read-only.

Conversation

@pcarlisle
Copy link
Contributor

@pcarlisle pcarlisle commented Jun 15, 2022

Go interprets ./... as distinct from ... when finding build targets. Avoid normalizing this path in order to keep the /. Go treats the targets ./... and all differently. When using ./... test targets will be ignored, whereas all includes them.

@pcarlisle pcarlisle force-pushed the ive-never-normalized-a-thing-in-my-life branch from 33d8e8f to 0ae9e6a Compare June 15, 2022 20:22
This breaks the common target `./...` which behaves differently from `...`
@pcarlisle pcarlisle force-pushed the ive-never-normalized-a-thing-in-my-life branch from 0ae9e6a to 65d65cc Compare June 15, 2022 20:27
@pcarlisle pcarlisle changed the title Ive never normalized a thing in my life Allow ./... as a build target Jun 15, 2022
@pcarlisle pcarlisle marked this pull request as ready for review June 15, 2022 20:28
@pcarlisle
Copy link
Contributor Author

pcarlisle commented Jun 15, 2022

This rewrote index.js a lot more than I expected, possibly I did something weird?

@pcarlisle
Copy link
Contributor Author

feel free to leave comments here but i'm going to open a new pr with the sameish contents against actions/go-dependency-submission

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant