Skip to content

Add change note: models for sqlite and sqlite_async libraries #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

Add change note: models for sqlite and sqlite_async libraries #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rust/ql/lib/change-notes/2025-07-08-sqlite-models.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
category: newQuery
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category 'newQuery' appears incorrect for adding library models. Library models typically fall under 'minorAnalysis' or 'majorAnalysis' depending on their impact, not 'newQuery' which is reserved for new query implementations.

Suggested change
category: newQuery
category: minorAnalysis

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category 'newQuery' is invalid for library-pack change notes. This should be changed to 'feature' since it documents the addition of new library APIs (models for sqlite and sqlite_async libraries).

Copilot generated this review using guidance from repository custom instructions.
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The category should be minorAnalysis instead of newQuery. According to the change note guidelines, newQuery is for new queries that find problems in code, while minorAnalysis is for new or improved support for frameworks/libraries. Since this change adds models for the sqlite and sqlite_async libraries, it falls under framework/library support.

Copilot generated this review using guidance from repository custom instructions.
---
* Added models for the `sqlite` and `sqlite_async` libraries.