Skip to content

Add change-note for new SQLite models and SQLi queries #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Add change-note for new SQLite models and SQLi queries #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cpp/ql/src/change-notes/2021-01-01-new-sqlite-models.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
category: newQuery
Copy link

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change note category should be 'minorAnalysis' rather than 'newQuery'. According to the project's change note guidelines, 'newQuery' is reserved for entirely new queries, while adding models and queries for specific libraries should use 'minorAnalysis'.

Copilot generated this review using guidance from repository custom instructions.
---
- Added models for the `sqlite` and `sqlite_async` libraries.
- Added queries to detect potential SQL injection vulnerabilities when using these libraries.
- Updated documentation to include examples and usage guidelines for the new SQLite models and queries.
- Added tests to ensure the accuracy and reliability of the new queries.
Comment on lines +4 to +7
Copy link

Copilot AI Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Change note files should typically describe a single change or closely related set of changes. This change note combines multiple distinct changes (models, queries, documentation, and tests) which should be separated into individual change note files. Consider splitting this into separate files like 2021-01-01-new-sqlite-models.md for the models and 2021-01-01-sqlite-sqli-queries.md for the queries.

Copilot uses AI. Check for mistakes.